-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ASIC/SDK health event #1340
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a first glance this looks good, i will do a full review after you will move that out of draft |
stephenxs
force-pushed
the
asic-sdk-health-event
branch
from
February 2, 2024 03:22
60813fb
to
3c0b96a
Compare
stephenxs
force-pushed
the
asic-sdk-health-event
branch
from
February 23, 2024 06:23
3c0b96a
to
a11dc0f
Compare
stephenxs
force-pushed
the
asic-sdk-health-event
branch
from
March 14, 2024 09:44
a11dc0f
to
243f223
Compare
stephenxs
force-pushed
the
asic-sdk-health-event
branch
from
March 27, 2024 06:50
243f223
to
0f6e902
Compare
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
reviewed
Apr 3, 2024
kcudnik
reviewed
Apr 3, 2024
kcudnik
requested changes
Apr 3, 2024
stephenxs
force-pushed
the
asic-sdk-health-event
branch
from
April 3, 2024 16:15
c0d77bf
to
ec6cb51
Compare
Failure is not relevant to the PR. Retried.
|
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Junchao-Mellanox
approved these changes
Apr 16, 2024
kcudnik
approved these changes
Apr 17, 2024
stephenxs
force-pushed
the
asic-sdk-health-event
branch
from
April 19, 2024 07:04
ec6cb51
to
67dc87c
Compare
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
stephenxs
force-pushed
the
asic-sdk-health-event
branch
from
April 29, 2024 08:00
67dc87c
to
d4ca979
Compare
@kcudnik could you please help to merge? |
kcudnik
approved these changes
Apr 30, 2024
Thanks @saiarcot895 for merging. @kcudnik fyi - needed to unblock an swss log issue. |
Do you need my help ? |
no, we are good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support ASIC/SDK health event