Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ASIC/SDK health event #1340

Merged
merged 5 commits into from
May 2, 2024

Conversation

stephenxs
Copy link
Contributor

Support ASIC/SDK health event

  1. Handle vendor SAI ASIC/SDK health event and encode it
  2. Pass it to swss through the communication channel.

@stephenxs stephenxs changed the title ASIC/SDK health event Support ASIC/SDK health event Jan 23, 2024
@kcudnik
Copy link
Collaborator

kcudnik commented Jan 23, 2024

a first glance this looks good, i will do a full review after you will move that out of draft

@stephenxs stephenxs force-pushed the asic-sdk-health-event branch from 60813fb to 3c0b96a Compare February 2, 2024 03:22
@stephenxs stephenxs force-pushed the asic-sdk-health-event branch from 3c0b96a to a11dc0f Compare February 23, 2024 06:23
@stephenxs stephenxs force-pushed the asic-sdk-health-event branch from a11dc0f to 243f223 Compare March 14, 2024 09:44
@stephenxs stephenxs marked this pull request as ready for review March 14, 2024 09:44
@stephenxs stephenxs force-pushed the asic-sdk-health-event branch from 243f223 to 0f6e902 Compare March 27, 2024 06:50
@stephenxs
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs stephenxs requested review from kcudnik and prsunny April 3, 2024 01:26
meta/SaiSerialize.cpp Outdated Show resolved Hide resolved
meta/SaiSerialize.cpp Outdated Show resolved Hide resolved
@stephenxs stephenxs force-pushed the asic-sdk-health-event branch from c0d77bf to ec6cb51 Compare April 3, 2024 16:15
@stephenxs
Copy link
Contributor Author

Failure is not relevant to the PR. Retried.

test_sub_port_intf_nhg_accel failed (1 runs remaining out of 2).
	<class 'AssertionError'>
	Unexpected number of keys: expected=6, received=4 (('oid:0x2d00000000084a', 'oid:0x2d00000000084d', 'oid:0x2d00000000084c', 'oid:0x2d00000000084b')), table="ASIC_STATE:SAI_OBJECT_TYPE_NEXT_HOP_GROUP_MEMBER"
	[<TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:1474>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:1410>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/dvslib/dvs_database.py:402>]
test_sub_port_intf_nhg_accel failed; it passed 0 out of the required 1 times.
	<class 'AssertionError'>
	Wrong # of default vrfs: 2, expected #: 1.
assert 2 == 1
  -2
  +1
	[<TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:1463>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:86>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:393>]
test_sub_port_intf_oper_down_with_pending_neigh_route_tasks failed (1 runs remaining out of 2).
	<class 'AssertionError'>
	Wrong # of default vrfs: 2, expected #: 1.
assert 2 == 1
  -2
  +1
	[<TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:1603>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:86>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:393>]
test_sub_port_intf_oper_down_with_pending_neigh_route_tasks failed; it passed 0 out of the required 1 times.
	<class 'AssertionError'>
	Wrong # of default vrfs: 2, expected #: 1.
assert 2 == 1
  -2
  +1
	[<TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:1603>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:86>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:393>]
test_nonflaky_dummy passed 1 out of the required 1 times. Success!

@stephenxs
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@stephenxs stephenxs requested a review from kcudnik April 4, 2024 00:23
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs stephenxs force-pushed the asic-sdk-health-event branch from ec6cb51 to 67dc87c Compare April 19, 2024 07:04
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs stephenxs force-pushed the asic-sdk-health-event branch from 67dc87c to d4ca979 Compare April 29, 2024 08:00
@stephenxs
Copy link
Contributor Author

@kcudnik @prsunny Could you help to merge this PR? Thanks

@liat-grozovik
Copy link
Collaborator

@kcudnik could you please help to merge?

@saiarcot895 saiarcot895 merged commit 8a0cc25 into sonic-net:master May 2, 2024
17 checks passed
@prsunny
Copy link
Contributor

prsunny commented May 2, 2024

Thanks @saiarcot895 for merging. @kcudnik fyi - needed to unblock an swss log issue.

@stephenxs stephenxs deleted the asic-sdk-health-event branch May 3, 2024 00:09
@kcudnik
Copy link
Collaborator

kcudnik commented May 3, 2024

Do you need my help ?

@prsunny
Copy link
Contributor

prsunny commented May 3, 2024

Do you need my help ?

no, we are good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants