Rename module from 'sswsdk' to 'swsssdk' #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stcheng
reviewed
Mar 28, 2017
| import sswsdk | ||
| db1 = sswsdk.SonicV1Connector() | ||
| import swsssdk | ||
| db1 = swsssdk.SonicV1Connector() |
There was a problem hiding this comment.
remove the v1 support? i don't think we still need it and even if it is kept here, it is no longer compatible with v1.
There was a problem hiding this comment.
@lguohan: I'm unfamiliar with this. Can you confirm? If so, I'll remove v1 support in this PR.
There was a problem hiding this comment.
we could merge this first and clean the legacy stuffs in the future
There was a problem hiding this comment.
OK. I created an issue for it: #5
lguohan
approved these changes
Mar 29, 2017
This was referenced Mar 29, 2017
stcheng
approved these changes
Mar 29, 2017
praveen-li
pushed a commit
to praveen-li/sonic-py-swsssdk
that referenced
this pull request
May 27, 2020
…" (sonic-net#4) This reverts commit 9918514.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR will require updating all references to this module.
The following repos appear to be affected:
sonic-buildimage(PR @ [swsssdk]: Update nomenclature: 'sswsdk' -> 'swsssdk' sonic-buildimage#445)sonic-snmpagent(PR @ Update nomenclature: 'sswsdk' -> 'swsssdk' sonic-snmpagent#20)sonic-dbsyncd(PR @ Update nomenclature: 'sswsdk' -> 'swsssdk' sonic-dbsyncd#2)The following pull requests appear to be affected:
[Portstat]: Read counters from database sonic-utilities#19(PR @ sonic-net/sonic-utilities@f8a9e8a)