[xcvrd] Don't log unnecessary messages upon empty transceiver change event #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xcvrd: Got event True {} in state 1
xcvrd: mapping from True {'-1': 'system_become_ready'} to system_become_ready
xcvrd: Got system_become_ready in normal state, ignored
What I did:
Don't need to do anything when the port_dict of transceiver_change is empty
How to verify:
Run on DUT to make sure xcvrd can detect tranceiver eeprom correctly and
there is no unmeaning logs anymore.
Signed-off-by: chiourung_huang <chiourung_huang@edge-core.com>
jleveque
approved these changes
Jun 3, 2020
|
@chiourung: If you feel this PR is still necessary, please fix the recent conflicts. |
|
Looks good to me. @keboliu: please review, also. |
|
LGTM. |
keboliu
approved these changes
Sep 9, 2020
jleveque
changed the title
abdosi
pushed a commit
that referenced
this pull request
Sep 19, 2020
…event (#53) When port_dict of transceiver_change is empty, do nothing rather than log messages like ``` xcvrd: Got event True {} in state 1 xcvrd: mapping from True {'-1': 'system_become_ready'} to system_become_ready xcvrd: Got system_become_ready in normal state, ignored ```
vdahiya12
pushed a commit
to vdahiya12/sonic-platform-daemons
that referenced
this pull request
Apr 4, 2022
…t#53) Signed-off-by: wangzhui <wangzhui@asterfusion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates unnecessary logs of the form:
What I did:
Don't need to do anything when the port_dict of transceiver_change is empty
How to verify:
Run on DUT to make sure xcvrd can detect tranceiver eeprom correctly and
there is no unmeaning logs anymore.
Signed-off-by: chiourung_huang chiourung_huang@edge-core.com