Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[thermalctld] Initialize fan led in thermalctld for the first run #167

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

Junchao-Mellanox
Copy link
Collaborator

Description

Initialize fan led in thermalcltd for the first run. Add a flag "led_initialized" in FanStatus and set it as False on init function. FanUpdater will use this flag to determine if fan led should be set even if no fan event detected.

Motivation and Context

Make sure fan led is initialized to correct color.

How Has This Been Tested?

Manual test

Additional Information (Optional)

@liat-grozovik
Copy link
Collaborator

@Junchao-Mellanox could it be an additional change to sonic-net/sonic-buildimage#7114

@liat-grozovik liat-grozovik requested a review from jleveque March 22, 2021 08:32
@jleveque jleveque merged commit cfa600f into sonic-net:master Mar 22, 2021
@Junchao-Mellanox Junchao-Mellanox deleted the init-fan-led branch March 25, 2021 00:40
jleveque pushed a commit that referenced this pull request May 27, 2021
Backport PR #167 since there is no clean cherry-pick.

#### Description
Initialize fan led in thermalcltd for the first run. Add a flag "led_initialized" in FanStatus and set it as False on __init__ function. FanUpdater will use this flag to determine if fan led should be set even if no fan event detected.
vdahiya12 pushed a commit to vdahiya12/sonic-platform-daemons that referenced this pull request Apr 4, 2022
Add GitHub pull request template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants