Changes in fan and psu base classes (1.0 platform API) related to pddf_2.0 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fk410167: Can you please explain how modifying the API version 1.0 plugins is related to adding support for 2.0 platform APIs? |
|
2.0 APIs are supported in PDDF. However, some platforms still support old
plugins. We added extra attributes to these plugins in previous PDDF PRs.
Till now, these extra plugin methods were used only from PDDF utils.
There has been a need of minor changes in those extra plugin methods as per
the current PDDF utilities. E.g. the type of variable of voltage, current
and power.
…-Fuzail
On Fri, 12 Jun 2020, 06:04 Joe LeVeque, ***@***.***> wrote:
@fk410167 <https://github.com/fk410167>: Can you please explain how
modifying the API version 1.0 plugins is related to adding support for 2.0
platform APIs?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#92 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMKFVJAS75JJPYK4QFIIWHDRWFZX7ANCNFSM4N3HW2LQ>
.
|
|
The changes are made in the base class of old plugins. e.g.
sonic_psu/psu_base.py
( not the 2.0 base class sonic_platform_base/psu_base.py)
…-Fuzail
On Fri, 12 Jun 2020, 06:00 Joe LeVeque, ***@***.***> wrote:
@fk410167 <https://github.com/fk410167>: What do you mean by "1.0
platform plugins"? The files you modified are part of the platform API 2.0;
they are not version 1.0 "plugins".
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#92 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMKFVJCQKEAOFWYPCQWRX23RWFZI5ANCNFSM4N3HW2LQ>
.
|
jleveque
approved these changes
Jun 22, 2020
|
@jleveque can you please merge it? thanks |
jleveque
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes in 1.0 platform plugins psu_base.py and fan_base.py. Changes are related to PDDF 2.0 changes.
psu_base.py:
fan_base.py:
Depends on:
sonic-net/SONiC#536