DeviceBase.get_name should raise NotImplementedError like other membe… #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keboliu
approved these changes
Nov 29, 2019
|
@jleveque I think we need this fix, what's your view? |
|
@keboliu: Yes, looks like this line was missed. |
jleveque
approved these changes
Dec 6, 2019
lguohan
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Dec 11, 2019
sonic-net/sonic-platform-common#71 [Bug fix] fix a syntax error which was introduced by last commit sonic-net/sonic-platform-common#70 Fix EEPROM vendor extension TLV number counting issue sonic-net/sonic-platform-common#62 Platform Driver Development Framework (PDDF): 1) Changes to psu base class (1.0 APIs) to support PDDF CLI utils, 2) Adding fan_base class to support PDDF fan CLI utils (comments incorporated) sonic-net/sonic-platform-common#68 DeviceBase.get_name should raise NotImplementedError like other member
abdosi
pushed a commit
that referenced
this pull request
Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue: DeviceBase.get_name does not raise NotImplementedError like other members.