Skip CDB and VDM for flat memory modules #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qinchuanares @aravindmani-1 can you review? |
qinchuanares
previously approved these changes
May 9, 2022
|
@prgeor Could you please check build failures?. |
qinchuanares
approved these changes
Jun 13, 2022
itamar-talmon
pushed a commit
to itamar-talmon/sonic-platform-common
that referenced
this pull request
Jan 12, 2023
* Skip CDB and VDM for flat memory modules * Improve code coverage * Fix test failure * Fix test failure * Fix test failure
|
@yxieca please help cherry pick. |
yxieca
pushed a commit
that referenced
this pull request
Jun 7, 2023
* Skip CDB and VDM for flat memory modules * Improve code coverage * Fix test failure * Fix test failure * Fix test failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Skip VDM and CDB support for flat memory modules like DAC
Motivation and Context
CDB or VDM support fields in Page01H does
not exist on flat memory module, so we should avoid reading this page for such modules to prevent read error/crash
How Has This Been Tested?
Verify Xcvrd does not crash due to presence of DAC cable
Additional Information (Optional)