Migrate from sonic-daemon-base package to sonic-py-common package #103
Conversation
|
Removed "Request for 201911 Branch" label, as backporting this change and the related changes will most likely be better performed by creating new PRs against the 201911 branch. |
| @@ -24,6 +24,10 @@ | |||
| 'sonic_sfp', | |||
| 'sonic_thermal', | |||
| ], | |||
| install_requires=[ | |||
| 'sonic-config-engine', # For portconfig. TODO: Remove this dependency | |||
There was a problem hiding this comment.
Note: This dependency was always needed, but was never explicitly specified. I added it here along with a TODO to eventually remove it (portconfig should eventually be moved into sonic-py-common).
| @@ -24,6 +24,10 @@ | |||
| 'sonic_sfp', | |||
| 'sonic_thermal', | |||
| ], | |||
| install_requires=[ | |||
| 'sonic-config-engine', # For portconfig. TODO: Remove this dependency | |||
| 'sonic-py-common' | |||
There was a problem hiding this comment.
how do you name the python3 version? sonic-py3-common?
There was a problem hiding this comment.
The installed package has the exact same name. They reside in different Python directories (/usr/local/lib/python2.X/dist-packages/sonic_py_common and /usr/local/lib/python3.X/dist-packages/sonic_py_common. This will help ease the transition from Python 2 to Python 3.
The .whl files have -py2 and -py3 suffices to differentiate.
|
@JLevesque84 FYI, I had to cherry-pick some part of PR to fix the compilation error generated when doing: [Submodule update] sonic-platform-common Please create PR for 201911 with other changes. Thanks !! |
|
You all keep tagging me on this, and I’m pretty sure im the wrong person
…Sent from my iPhone
On Sep 6, 2020, at 8:52 AM, abdosi ***@***.***> wrote:
@JLevesque84 FYI, I had to cherry-pick some part of PR to fix the compilation error generated when doing:
[Submodule update] sonic-platform-common
Multi-Asic changes PR #100 , commit into 201911.
Please create PR for 201911 with other changes. Thanks !!
@judyjoseph
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
oops Sorry. Tagging @jleveque |
As part of consolidating all common Python-based functionality into the new sonic-py-common package, this pull request migrates from importing the sonic-daemon-base package to importing the sonic-py-common package. This is the next step toward resolving sonic-net/sonic-buildimage#4999.