Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PINS Working Group initial code commit. #1

Merged
merged 12 commits into from
Nov 20, 2021
Merged

PINS Working Group initial code commit. #1

merged 12 commits into from
Nov 20, 2021

Conversation

rhalstea
Copy link
Collaborator

  • Create a P4Runtime service to be used by SONiC.
  • Create a P4 Program describing a SONiC switch.
  • support pushing switch configurations.
  • support ACL table definitions.
  • support insert/delete/modify in APPL_DB.
  • support for L3 forwarding, WCMP, and ACL tables.
  • support for response path through APPL_STATE_DB.
  • support arbitration for multiple controllers and roles.
  • support PacketIO.

Co-authored-by: Robert Halstead rhalstea@google.com
Co-authored-by: Srikishen Pondicherry Shanmugam kishanps@google.com
Co-authored-by: Steffen Smolka smolkaj@google.com
Co-authored-by: Jonathan Dilorenzo dilo@google.com
Co-authored-by: Richard Yu richardyu@google.com
Co-authored-by: Brian O'Connor bocon@opennetworking.org
Co-authored-by: Konstantin Weitz konne@google.com
Co-authored-by: Stefan Heule heule@google.com
Co-authored-by: Tianyu Xia tyxia@google.com

@rhalstea
Copy link
Collaborator Author

For Info: @kishanps, @smolkaj, @bocon13
For Review: @qiluo-msft, @abdosi, @prsunny

@smolkaj
Copy link
Collaborator

smolkaj commented Oct 15, 2021

We're missing @atmanmehta as one of the co-authors.

Copy link

@yxieca yxieca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer / Heads up

I don't think I can review 54K LOC in reasonable amount of time. Sign off base on no impact to current sonic image.

There would be a change in the future to link this repo as submodule of buidimage. By then there should be a test plan presented in test subgroup.

PINS Working Group and others added 3 commits October 27, 2021 17:41
* Create a P4Runtime service to be used by SONiC.
* Create a P4 Program describing a SONiC switch.
* support pushing switch configurations.
* support ACL table definitions.
* support insert/delete/modify in APPL_DB.
* support for L3 forwarding, WCMP, and ACL tables.
* support for response path through APPL_STATE_DB.
* support arbitration for multiple controllers and roles.
* support PacketIO.

Co-authored-by: Robert Halstead <rhalstea@google.com>
Co-authored-by: Srikishen Pondicherry Shanmugam <kishanps@google.com>
Co-authored-by: Steffen Smolka <smolkaj@google.com>
Co-authored-by: Jonathan Dilorenzo <dilo@google.com>
Co-authored-by: Richard Yu <richardyu@google.com>
Co-authored-by: Atman Mehta <atmanm@google.com>
Co-authored-by: Brian O'Connor <bocon@opennetworking.org>
Co-authored-by: Konstantin Weitz <konne@google.com>
Co-authored-by: Stefan Heule <heule@google.com>
Co-authored-by: Tianyu Xia <tyxia@google.com>
PINS uses Bazel 4.0.0
@bocon13 bocon13 changed the title pins: PINS Working Group initial code commit. PINS Working Group initial code commit. Oct 28, 2021
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@bocon13 bocon13 force-pushed the pins_review branch 8 times, most recently from bea9725 to a033ce4 Compare November 20, 2021 04:16
@bocon13 bocon13 merged commit ad4faad into main Nov 20, 2021
bocon13 added a commit that referenced this pull request Nov 20, 2021
* Create a P4Runtime service to be used by SONiC.
* Create a P4 Program describing a SONiC switch.
* Support pushing switch configurations.
* Support ACL table definitions.
* Support insert/delete/modify in APPL_DB.
* Support for L3 forwarding, WCMP, and ACL tables.
* Support for response path through APPL_STATE_DB.
* Support arbitration for multiple controllers and roles.
* Support PacketIO.
* Add Github Actions CI

Co-authored-by: Atman Mehta <atmanm@google.com>
Co-authored-by: Brian O'Connor <bocon@opennetworking.org>
Co-authored-by: Jonathan Dilorenzo <dilo@google.com>
Co-authored-by: Konstantin Weitz <konne@google.com>
Co-authored-by: Richard Yu <richardyu@google.com>
Co-authored-by: Robert Halstead <rhalstea@google.com>
Co-authored-by: Srikishen Pondicherry Shanmugam <kishanps@google.com>
Co-authored-by: Stefan Heule <heule@google.com>
Co-authored-by: Steffen Smolka <smolkaj@google.com>
Co-authored-by: Tianyu Xia <tyxia@google.com>
@bocon13 bocon13 deleted the pins_review branch November 20, 2021 04:54
rhalstea added a commit to rhalstea/sonic-pins that referenced this pull request Oct 31, 2022
rhalstea added a commit that referenced this pull request Nov 2, 2022
* Bring P4RT up to data with P4Orch for November release.

* Addressing review comments #1

* Addressing review comments #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants