Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cisco: Skip Watermark test for multi-DUT cases. #9810

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Cisco: Skip Watermark test for multi-DUT cases. #9810

merged 3 commits into from
Sep 22, 2023

Conversation

rraghav-cisco
Copy link
Contributor

@rraghav-cisco rraghav-cisco commented Sep 1, 2023 •
edited
Loading

The Watermark tests need the values for destination port, but qos.yaml params are read for the source port only. Until the infra provides a way to get the dst qos parameters, we need to skip the tests.

@rraghav-cisco
Copy link
Contributor Author

------------------------------------------------------------------------------------------------------------------ live log sessionfinish ------------------------------------------------------------------------------------------------------------------
05:24:26 init.pytest_terminal_summary L0064 INFO | Can not get Allure report URL. Please check logs
================================================================================================================= short test summary info ==================================================================================================================
SKIPPED [3] /data/tests/qos/qos_sai_base.py:2048: AllportQueueWaterMark is skipped for multiDUT scenarios.
=============================================================================================================== 3 skipped in 1143.20 seconds ===============================================================================================================
AzDevOps@qos-sonic-mgmt:/data/tests$

@rraghav-cisco rraghav-cisco changed the title Cisco: Skip AllPortQueueWaterMark test for multi-DUT cases. Cisco: Skip Watermark test for multi-DUT cases. Sep 7, 2023
XuChen-MSFT
XuChen-MSFT approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@XuChen-MSFT XuChen-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. @vmittal-msft I approved, please review multi-dut's change as well.

@abdosi abdosi merged commit 4835e49 into sonic-net:master Sep 22, 2023
14 checks passed
@abdosi abdosi mentioned this pull request Sep 22, 2023
Merged
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Oct 24, 2023
@rraghav-cisco @mssonicbld
Cisco: Skip Watermark test for multi-DUT cases. (sonic-net#9810)
06b9c50
@mssonicbld
Copy link
Collaborator

@rraghav-cisco PR conflicts with 202205 branch

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #10448

@mssonicbld mssonicbld mentioned this pull request Oct 24, 2023
Merged
mssonicbld pushed a commit that referenced this pull request Oct 25, 2023
@rraghav-cisco @mssonicbld
Cisco: Skip Watermark test for multi-DUT cases. (#9810)
a6ed783
@rraghav-cisco
Copy link
Contributor Author

@mssonicbld : 202205 PR: #9898

AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Jan 25, 2024
@rraghav-cisco @AharonMalkin
Cisco: Skip Watermark test for multi-DUT cases. (sonic-net#9810)
a65b01e
wangxin pushed a commit that referenced this pull request Feb 2, 2024
@rraghav-cisco
Porting skip-watermark-tests to 202205. (#9898)
dd7eb85 
Cherry-pick of PR: #9810
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuChen-MSFT XuChen-MSFT XuChen-MSFT approved these changes

@wsycqyz wsycqyz Awaiting requested review from wsycqyz

@vmittal-msft vmittal-msft Awaiting requested review from vmittal-msft

Assignees
No one assigned
Labels
Approved for 202205 branch Approved for 202305 branch Cherry Pick Conflict_202205 Included in 202205 branch Included in 202305 branch Request for 202205 branch Request for 202305 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rraghav-cisco @mssonicbld @XuChen-MSFT @wangxin @abdosi