Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permission of /tmp to unblock copp test #9756

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

bingwang-ms
Copy link
Collaborator

@bingwang-ms bingwang-ms commented Aug 30, 2023

Description of PR

Summary:
This PR is to fix the permission of /tmp to unblock the copp test.
Because of issue sonic-net/sonic-buildimage#16034 , the /tmp directory in syncd docker has incorrect permission.
This PR unblocked the issue by setting the permission to 777 before apt install.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305

Approach

What is the motivation for this PR?

This PR is to fix permission for /tmp to unblock copp test.

How did you do it?

Change the permission of /tmp to 777 before apt get.

How did you verify/test it?

The change is verified on a MSN-2700 device

collected 14 items                                                                                                                                                         

copp/test_copp.py::TestCOPP::test_policer[str-msn2700-02-ARP]  ^HPASSED                                                                                                 [  7%]
copp/test_copp.py::TestCOPP::test_policer[str-msn2700-02-IP2ME] PASSED                                                                                               [ 14%]
copp/test_copp.py::TestCOPP::test_policer[str-msn2700-02-SNMP]  ^HPASSED                                                                                                [ 21%]
copp/test_copp.py::TestCOPP::test_policer[str-msn2700-02-SSH] PASSED                                                                                                 [ 28%]
copp/test_copp.py::TestCOPP::test_no_policer[str-msn2700-02-BGP] PASSED                                                                                              [ 35%]
copp/test_copp.py::TestCOPP::test_no_policer[str-msn2700-02-DHCP] PASSED                                                                                             [ 42%]
copp/test_copp.py::TestCOPP::test_no_policer[str-msn2700-02-DHCP6] PASSED                                                                                            [ 50%]
copp/test_copp.py::TestCOPP::test_no_policer[str-msn2700-02-LACP]  ^HPASSED                                                                                             [ 57%]
copp/test_copp.py::TestCOPP::test_no_policer[str-msn2700-02-LLDP] PASSED                                                                                             [ 64%]
copp/test_copp.py::TestCOPP::test_no_policer[str-msn2700-02-UDLD] PASSED                                                                                             [ 71%]
copp/test_copp.py::TestCOPP::test_add_new_trap[str-msn2700-02] PASSED                                                                                                [ 78%] ^H
copp/test_copp.py::TestCOPP::test_remove_trap[str-msn2700-02-delete_feature_entry]  ^HPASSED                                                                            [ 85%] ^H
copp/test_copp.py::TestCOPP::test_remove_trap[str-msn2700-02-disable_feature_status] PASSED                                                                          [ 92%] ^H
copp/test_copp.py::TestCOPP::test_trap_config_save_after_reboot[str-msn2700-02]  ^HPASSED                                                                               [100%] ^H

================================================================= 14 passed, 3 warnings in 2959.99 seconds =================================================================

Any platform specific information?

The issue is Mellanox platform specific. But the change is applied to all platforms.

Supported testbed topology if it's a new test case?

Not a new test case.

Documentation

Copy link
Contributor

@ZhaohuiS ZhaohuiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bingwang-ms bingwang-ms merged commit 552826b into sonic-net:master Aug 30, 2023
12 checks passed
@bingwang-ms
Copy link
Collaborator Author

@StormLiangMS Can you please approve this PR for 202305 branch? Thanks

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #10004

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants