-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore the MAC address of VLAN at the end of test_host_vlan #9542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yejianquan
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cherry-pick PR to 202012: #9681 |
Cherry-pick PR to 202305: #9682 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 28, 2023
This was referenced Aug 28, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 28, 2023
Cherry-pick PR to 202205: #9683 |
7 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Aug 28, 2023
mssonicbld
pushed a commit
that referenced
this pull request
Aug 28, 2023
mssonicbld
pushed a commit
that referenced
this pull request
Aug 28, 2023
mssonicbld
added
Included in 202012 branch
and removed
Created PR to 202012 branch
labels
Aug 28, 2023
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
This PR is to fix a code bug in
test_host_vlan.py
.The fixture
setup_host_vlan_intf_mac
changed the MAC address ofVlan1000
but didn't restore it.That results in test failure in
test_interfaces.py
This PR fixed the issue by restoring the MAC address in the teardown of fixture
setup_host_vlan_intf_mac
.Type of change
Back port request
Approach
What is the motivation for this PR?
This PR is to fix a code bug in
test_host_vlan.py
.How did you do it?
This PR fixed the issue by restoring the MAC address in the teardown of fixture
setup_host_vlan_intf_mac
.How did you verify/test it?
The change is verified on a SN4600 testbed. The MAC address of Vlan1000 is restored after test running.
Any platform specific information?
No.
Supported testbed topology if it's a new test case?
Not a new test case.
Documentation