-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Snappi] Update PFC helper for bug fix #9532
Merged
developfast
merged 1 commit into
sonic-net:master
from
developfast:unreferenced_local_var_fix
Aug 17, 2023
Merged
[Snappi] Update PFC helper for bug fix #9532
developfast
merged 1 commit into
sonic-net:master
from
developfast:unreferenced_local_var_fix
Aug 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neethajohn
approved these changes
Aug 17, 2023
Cherry-pick PR to 202205: #9559 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 18, 2023
6 tasks
@developfast PR conflicts with 202012 branch |
mssonicbld
pushed a commit
that referenced
this pull request
Aug 18, 2023
mssonicbld
added
Included in 202205 branch
and removed
Created PR to 202205 branch
labels
Aug 18, 2023
yxieca
added
Approved for 202012 branch
and removed
Cherry Pick Conflict_202012
Approved for 202012 branch
labels
Aug 18, 2023
@developfast PR conflicts with 202012 branch |
Cherry-pick PR to 202305: #9680 |
6 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Aug 28, 2023
mssonicbld
added
Included in 202305 branch
and removed
Created PR to 202305 branch
labels
Aug 28, 2023
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: PR 8661 (validating PFC frames) introduced an unwanted indent which resulted in a
local variable referenced before assignment
error. This PR resolves that issue.Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Bug fix.
How did you do it?
How did you verify/test it?
On nightly testbed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation