[fdb] Address failures on td2 asics for fdb mac move test #9487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neetha John <nejo@microsoft.com>
|
LGTM. |
bingwang-ms
approved these changes
Aug 16, 2023
|
@neethajohn PR conflicts with 202012 branch |
|
@neethajohn PR conflicts with 202205 branch |
|
Cherry-pick PR to 202305: #9677 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 28, 2023
…9487) Signed-off-by: Neetha John <nejo@microsoft.com> What is the motivation for this PR? On certain platforms with low disk space, failures are seen occassionally on running the test_fdb_mac_move case. This testcase runs in a loop and the number of times the loop is executed is dependent on the completeness_level setting. Lot of syslog messages are generated per loop and for completeness_level settings of 'confident' and above, it can lead to disk full case for certain platforms. This PR resets the completeness_level to basic for td2 platforms so as to reduce the number of iterations of test run. How did you verify/test it? Ran the testcase multiple times against t0-backend topology and no longer see failures
6 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Aug 28, 2023
Signed-off-by: Neetha John <nejo@microsoft.com> What is the motivation for this PR? On certain platforms with low disk space, failures are seen occassionally on running the test_fdb_mac_move case. This testcase runs in a loop and the number of times the loop is executed is dependent on the completeness_level setting. Lot of syslog messages are generated per loop and for completeness_level settings of 'confident' and above, it can lead to disk full case for certain platforms. This PR resets the completeness_level to basic for td2 platforms so as to reduce the number of iterations of test run. How did you verify/test it? Ran the testcase multiple times against t0-backend topology and no longer see failures
mssonicbld
added
Included in 202305 branch
and removed
Created PR to 202305 branch
labels
This was referenced Aug 30, 2023
neethajohn
added a commit
that referenced
this pull request
Aug 31, 2023
Signed-off-by: Neetha John <nejo@microsoft.com> Backport #9487 changes into 202012
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
…9487) Signed-off-by: Neetha John <nejo@microsoft.com> What is the motivation for this PR? On certain platforms with low disk space, failures are seen occassionally on running the test_fdb_mac_move case. This testcase runs in a loop and the number of times the loop is executed is dependent on the completeness_level setting. Lot of syslog messages are generated per loop and for completeness_level settings of 'confident' and above, it can lead to disk full case for certain platforms. This PR resets the completeness_level to basic for td2 platforms so as to reduce the number of iterations of test run. How did you verify/test it? Ran the testcase multiple times against t0-backend topology and no longer see failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Type of change
Back port request
Approach
What is the motivation for this PR?
On certain platforms with low disk space, failures are seen occassionally on running the test_fdb_mac_move case. This testcase runs in a loop and the number of times the loop is executed is dependent on the completeness_level setting. Lot of syslog messages are generated per loop and for completeness_level settings of 'confident' and above, it can lead to disk full case for certain platforms. This PR resets the completeness_level to basic for td2 platforms so as to reduce the number of iterations of test run.
How did you verify/test it?
Ran the testcase multiple times against t0-backend topology and no longer see failures