Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double commit #8546 add overflow_egress for PGDropTest multi-asic #9464

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

zhixzhu
Copy link
Contributor

@zhixzhu zhixzhu commented Aug 15, 2023

Description of PR

Double commit #8546
testQosSaiPGDrop is cisco only case, make it same as 202205 branch.

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@zhixzhu zhixzhu marked this pull request as ready for review August 15, 2023 21:20
@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/saitests/py3/sai_qos_tests.py:255:18: E225 missing whitespace around operator
tests/saitests/py3/sai_qos_tests.py:255:19: F821 undefined name 'sai_thrift_read_pg_occupancy'
tests/saitests/py3/sai_qos_tests.py:260:17: E225 missing whitespace around operator
tests/saitests/py3/sai_qos_tests.py:260:18: F821 undefined name 'sai_thrift_read_pg_occupancy'
tests/saitests/py3/sai_qos_tests.py:264:17: E128 continuation line under-indented for visual indent
tests/saitests/py3/sai_qos_tests.py:265:17: E122 continuation line missing indentation or outdented
tests/saitests/py3/sai_qos_tests.py:3880:13: E225 missing whitespace around operator
tests/saitests/py3/sai_qos_tests.py:3881:12: E225 missing whitespace around operator
tests/saitests/py3/sai_qos_tests.py:3882:19: E225 missing whitespace around operator
tests/saitests/py3/sai_qos_tests.py:3883:11: E225 missing whitespace around operator
tests/saitests/py3/sai_qos_tests.py:3884:14: E225 missing whitespace around operator
...
[truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/saitests/py3/sai_qos_tests.py:255:18: E225 missing whitespace around operator
tests/saitests/py3/sai_qos_tests.py:255:19: F821 undefined name 'sai_thrift_read_pg_occupancy'
tests/saitests/py3/sai_qos_tests.py:260:17: E225 missing whitespace around operator
tests/saitests/py3/sai_qos_tests.py:260:18: F821 undefined name 'sai_thrift_read_pg_occupancy'
tests/saitests/py3/sai_qos_tests.py:264:17: E128 continuation line under-indented for visual indent
tests/saitests/py3/sai_qos_tests.py:265:17: E122 continuation line missing indentation or outdented
tests/saitests/py3/sai_qos_tests.py:3937:53: E128 continuation line under-indented for visual indent

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/saitests/py3/sai_qos_tests.py:266:19: E122 continuation line missing indentation or outdented
tests/saitests/py3/sai_qos_tests.py:267:19: E122 continuation line missing indentation or outdented
tests/saitests/py3/switch.py:890:9: F405 'SAI_INGRESS_PRIORITY_GROUP_STAT_CURR_OCCUPANCY_BYTES' may be undefined, or defined from star imports: ptf.thriftutils, switch_sai_thrift.sai_headers, switch_sai_thrift.ttypes

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

Signed-off-by: Zhixin Zhu <zhixzhu@cisco.com>
@wangxin wangxin merged commit 9dd33d7 into sonic-net:master Aug 17, 2023
11 checks passed
XuChen-MSFT added a commit to XuChen-MSFT/sonic-mgmt that referenced this pull request Aug 22, 2023
StormLiangMS pushed a commit that referenced this pull request Aug 23, 2023
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Aug 24, 2023
mssonicbld pushed a commit that referenced this pull request Aug 25, 2023
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Jan 25, 2024
Signed-off-by: Zhixin Zhu <zhixzhu@cisco.com>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Jan 25, 2024
@abdosi
Copy link
Contributor

abdosi commented Feb 23, 2024

@zhixzhu : please check if this PR is their in 202305

@zhixzhu
Copy link
Contributor Author

zhixzhu commented Feb 23, 2024

@abdosi Yes, it got in 202305 via #10725

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants