Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong bool argument parsing in upgrade_image.py script #9452

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Fix wrong bool argument parsing in upgrade_image.py script #9452

merged 1 commit into from
Aug 15, 2023

Commits on Aug 15, 2023

  1. Fix wrong bool argument parsing in upgrade_image.py script 

    The upgrade_image.py script defined some bool  type arguments.
However, "action" is not specified while defining these arguments.

The result is that if user pass in arguments like below, the argument
will be still be evaluated to True as python by default casting
string "False" to bool value True.

./upgrade_image.py --enable-fips Flase

The fix is to take advantage of setuptools.distutils.util.strtobool.

With tool, any values like below passed in to this type of arguments
would be evaluated to integer 0:
"n", "no", "No", "NO", "False", "false", "FALSE", "FaLsE", ...

Any argument value like below would be evaluated to integer 1:
"y", "yes", "Yes", "YES", "True", "true", "TRUE", "TrUe", ...

Signed-off-by: Xin Wang <xiwang5@microsoft.com>
    @wangxin
    wangxin committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    b6ff440 View commit details
    Browse the repository at this point in the history