Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Arista products from sku-sensors-data.yml #9415

Merged
merged 1 commit into from
Aug 16, 2023

Commits on Aug 11, 2023

  1. Remove Arista products from sku-sensors-data.yml

    The `platform_tests/test_sensors.py` rely on the information provided
    in this config file to check for the existance of sysfs paths.
    
    This test was introduced before the Platform API existed and did have
    some purpose then. However all SONiC platform daemons now rely on the
    Platform API which is tested by numerous tests under `platform_tests`.
    
    There is no longer a need to hardcode sysfs paths for products.
    Keeping this data there is bound to generate recurring issues in the
    future and translate directly into maintenance burden.
    
    Some sysfs paths are just not deterministic. They will depend on which
    driver is loaded first and whatnot which is inherently flaky for a test
    to rely on.
    Staphylo committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    a3079af View commit details
    Browse the repository at this point in the history