-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UT for orchagent watchdog #8306
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
import logging | ||
import pytest | ||
import time | ||
from tests.common.helpers.assertions import pytest_assert | ||
|
||
pytestmark = [ | ||
pytest.mark.disable_loganalyzer, | ||
pytest.mark.topology('any') | ||
] | ||
|
||
logger = logging.getLogger(__name__) | ||
|
||
SLEEP_TIME = 10 | ||
|
||
|
||
@pytest.fixture | ||
def pause_orchagent(duthost): | ||
# find orchagent pid | ||
pid = duthost.shell( | ||
r"pgrep orchagent", | ||
module_ignore_errors=True)['stdout'] | ||
logger.info('Get orchagent pid: {}'.format(pid)) | ||
|
||
# pause orchagent and clear syslog | ||
duthost.shell(r"sudo kill -STOP {}".format(pid), module_ignore_errors=True) | ||
duthost.shell(r"sudo truncate -s 0 /var/log/syslog", module_ignore_errors=True) | ||
|
||
yield | ||
|
||
# resume orchagent and clear syslog | ||
duthost.shell(r"sudo kill -CONT {}".format(pid), module_ignore_errors=True) | ||
duthost.shell(r"sudo truncate -s 0 /var/log/syslog", module_ignore_errors=True) | ||
|
||
|
||
def test_orchagent_watchdog(duthosts, enum_rand_one_per_hwsku_hostname, pause_orchagent): | ||
duthost = duthosts[enum_rand_one_per_hwsku_hostname] | ||
|
||
result = duthost.shell( | ||
r"docker exec -i swss sh -c 'test -f /etc/supervisor/watchdog_processes && echo exist'", | ||
module_ignore_errors=True)['stdout'] | ||
logger.info('Check watchdog exist: {}'.format(result)) | ||
if result != 'exist': | ||
pytest.skip("Skip orchagent watchdog test.") | ||
|
||
# wait watchdog emit alert, orchagent watchdog timeout is 60 seconds | ||
WATCHDOG_TIMEOUT = 120 | ||
current_attempt = 0 | ||
while (True): | ||
time.sleep(SLEEP_TIME) | ||
alert = duthost.shell( | ||
r"sudo cat /var/log/syslog | grep 'is stuck in namespace'", | ||
module_ignore_errors=True)['stdout'] | ||
logger.info('Get alert from host: {}'.format(alert)) | ||
if "orchagent" in str(alert): | ||
return | ||
else: | ||
# orchagent watchdog timeout is 60 seconds | ||
if current_attempt >= WATCHDOG_TIMEOUT/SLEEP_TIME: | ||
pytest_assert( | ||
False, | ||
"orchagent watchdog did not been trigger after {} seconds".format(WATCHDOG_TIMEOUT)) | ||
else: | ||
current_attempt += 1 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Magic number. How do you get the value? Is it too long or possible too short if anyone change code accidently? #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The watchdog will send alert after 60 seconds, so I wait for 60*2 here.