Get bgp neighbor information only if bgp service is in critical process #7046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and added in critical process list. Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com> (cherry picked from commit 39f1d5a8c41f678f876952da7f48492fa5873635)
|
closing this as #7042 should fix the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Suvarna Meenakshi sumeenak@microsoft.com
(cherry picked from commit 39f1d5a8c41f678f876952da7f48492fa5873635)
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Container autorestart test fails on supervisor with error:
RunAnsibleModuleFail: run module bgp_facts failed, Ansible Results => {"changed": false, "failed": true, "msg": "Command failed rc=1, out=, err=Error response from daemon: Container f494b23f9428414d38b7ad8604a712914cbfee9dda5e9294f442779b6a1c1101 is not running\n"}
autorestart/test_container_autorestart.py:419: in run_test_on_single_container
up_bgp_neighbors = duthost.get_bgp_neighbors_per_asic("established")
This is seen after sonic-net/sonic-buildimage#11796 where bgp service is disabled on supervisor.
How did you do it?
get bgp neighbor information only if bgp container name is in the duthost critical_service list.
How did you verify/test it?
Ran autorestart test on chassis platform and test passes.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation