Move skip check of test_passwd_hardening to tests_mark_conditions.yaml #6429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
|
@davidpil2002 Could you please take a look? Please let me know if you have any objection, thanks. |
|
tests_mark_conditions.yaml - this file is a configuration file or its require to add some code? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ZhaohuiS
changed the title
tests_mark_conditions.yaml is a configuration file, test script or case will be skipped at the very beginning of test run, it doesn't have to run sanity check and other fixtures, it's best way to skip script or case. Because it will save us time to avoid running sanity check or other fixtures and also it could avoid the errors during these checks or fixtures. |
Azarack
pushed a commit
to Azarack/sonic-mgmt
that referenced
this pull request
Oct 17, 2022
) What is the motivation for this PR? test_passw_hardening is unable to run on master image because sonic-net/sonic-buildimage#12138 hasn't been merged. But after running it on 202205 image which supports passw-harden(enabled in this PR sonic-net/sonic-buildimage#12025), found an issue and raised here sonic-net#6428. I think that it's better to skip test case in tests_mark_conditions.yaml instead of in test script. How did you do it? Move skip condition to tests_mark_conditions.yaml Add an issue in skip condition. After it's been fixed, we can run this script. How did you verify/test it? Run passw_hardening/test_passw_hardening.py Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
allen-xf
pushed a commit
to allen-xf/sonic-mgmt
that referenced
this pull request
Oct 28, 2022
) What is the motivation for this PR? test_passw_hardening is unable to run on master image because sonic-net/sonic-buildimage#12138 hasn't been merged. But after running it on 202205 image which supports passw-harden(enabled in this PR sonic-net/sonic-buildimage#12025), found an issue and raised here sonic-net#6428. I think that it's better to skip test case in tests_mark_conditions.yaml instead of in test script. How did you do it? Move skip condition to tests_mark_conditions.yaml Add an issue in skip condition. After it's been fixed, we can run this script. How did you verify/test it? Run passw_hardening/test_passw_hardening.py Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zhaohui Sun zhaohuisun@microsoft.com
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
test_passw_hardeningis unable to run on master image because sonic-net/sonic-buildimage#12138 hasn't been merged.But after running it on 202205 image which supports passw-harden(enabled in this PR sonic-net/sonic-buildimage#12025), found an issue and raised here #6428.
I think that it's better to skip test case in tests_mark_conditions.yaml instead of in test script.
How did you do it?
How did you verify/test it?
Run passw_hardening/test_passw_hardening.py
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation