-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mellanox] Support PSU power threshold checking #6288
Merged
wangxin
merged 15 commits into
sonic-net:master
from
stephenxs:psu-power-threshold-checking-github
Sep 8, 2022
Merged
[Mellanox] Support PSU power threshold checking #6288
wangxin
merged 15 commits into
sonic-net:master
from
stephenxs:psu-power-threshold-checking-github
Sep 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
- update ambient sensors and check db - update power and check db Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
- allure report - CLI option Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
stephenxs
changed the title
[Mellanox] PSU power threshold exceeding check
[Mellanox] PSU power threshold checking
Sep 5, 2022
stephenxs
changed the title
[Mellanox] PSU power threshold checking
[Mellanox] Support PSU power threshold checking
Sep 5, 2022
This pull request introduces 1 alert when merging 36ed54a into 2516c9c - view on LGTM.com new alerts:
|
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Fixed. |
Junchao-Mellanox
approved these changes
Sep 6, 2022
Failed on t0 due to error messages. Retried:
|
/azp run Azure.sonic-mgmt |
Azure Pipelines successfully started running 1 pipeline(s). |
wangxin
approved these changes
Sep 8, 2022
Azarack
pushed a commit
to Azarack/sonic-mgmt
that referenced
this pull request
Oct 17, 2022
What is the motivation for this PR? Implement the regression test case of PSU power threshold exceeding check. 1. It can be done on a per vendor/platform basis only because the way to trigger PSU power threshold exceeding varies among vendors and platforms. 2. Support parsing WARNING state in the output of show platform psustatus How did you do it? We implement the test as a mock test because * It's not able to meet the conditions to trigger the PSU power to exceed its threshold in any regression test bed, (which requires 100% utilization of throughput and high power-consumption xSFP modules * PSU power threshold exceeding checking is not supported on all testbeds. If we would like to run the test on a test bed which does not physically support it, we also need to mock it. How did you verify/test it? Manually test and run regression test. Any platform specific information? Mellanox platforms only. Signed-off-by: Stephen Sun <stephens@nvidia.com>
allen-xf
pushed a commit
to allen-xf/sonic-mgmt
that referenced
this pull request
Oct 28, 2022
What is the motivation for this PR? Implement the regression test case of PSU power threshold exceeding check. 1. It can be done on a per vendor/platform basis only because the way to trigger PSU power threshold exceeding varies among vendors and platforms. 2. Support parsing WARNING state in the output of show platform psustatus How did you do it? We implement the test as a mock test because * It's not able to meet the conditions to trigger the PSU power to exceed its threshold in any regression test bed, (which requires 100% utilization of throughput and high power-consumption xSFP modules * PSU power threshold exceeding checking is not supported on all testbeds. If we would like to run the test on a test bed which does not physically support it, we also need to mock it. How did you verify/test it? Manually test and run regression test. Any platform specific information? Mellanox platforms only. Signed-off-by: Stephen Sun <stephens@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Support test case for PSU power threshold exceeding check.
Signed-off-by: Stephen Sun stephens@nvidia.com
Type of change
Back port request
Approach
What is the motivation for this PR?
It can be done on a per vendor/platform basis only because the way to trigger PSU power threshold exceeding varies among vendors and platforms.
WARNING
state in the output ofshow platform psustatus
How did you do it?
We implement the test as a mock test because
How did you verify/test it?
Manually test and run regression test.
Any platform specific information?
Mellanox platforms only.
Supported testbed topology if it's a new test case?
Documentation