[test_reboot] Check time passed before checking warmboot finalizer state #4706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingwang-ms
reviewed
Nov 16, 2021
yxieca
approved these changes
Nov 16, 2021
bingwang-ms
approved these changes
Nov 17, 2021
AntonHryshchuk
pushed a commit
to AntonHryshchuk/sonic-mgmt
that referenced
this pull request
Jan 4, 2022
…ate (sonic-net#4706) Fix false negatives in test_reboot.py::test_warm_reboot. If more than 90s have passed since issue of warm-reboot, the test should fail, even if warmboot FINALIZER state has reached activating. Without this change, if in the first attempt to check if FINALIZER state reaches activating passes, the time passed since reboot is not checked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Fix false negatives in test_reboot.py::test_warm_reboot when finalizer state is checked before checking time passed since warm-reboot.
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix false negatives in
test_reboot.py::test_warm_reboot.If more than 90s have passed since issue of warm-reboot, the test should fail, even if warmboot FINALIZER state has reached
activating.Without this change, if in the first attempt to check if FINALIZER state reaches
activatingpasses, the time passed since reboot is not checked.How did you do it?
The sequence of checks is now reverted - first check the time elapsed since issue of warm-reboot, then check the finalizer state. If elapsed time is greater than the wait (default 90s), and finalizer still reaches activating state, then fail the test.
How did you verify/test it?
With the fix, the false negative scenario is not seen. The test fails if elapsed time is greater than the wait period.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation