integrated reboot-cause history into reboot tests in platfrom_tests/test_reboot.py #4270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JibinBao
changed the title
|
This pull request introduces 1 alert when merging f8100cc into 7c947a7 - view on LGTM.com new alerts:
|
lguohan
reviewed
Sep 15, 2021
| 2021_09_09_13_30_52 soft-reboot Thu 09 Sep 2021 01:30:24 PM UTC admin N/A | ||
| 2021_09_09_13_24_17 reboot Thu 09 Sep 2021 01:23:17 PM UTC admin N/A | ||
| """ | ||
| reboot_cause_history_got = dut.show_and_parse("show reboot-cause history") |
There was a problem hiding this comment.
show reboot-cause history is a new feature in 202012, can we make it a new test and skip the test for release before 202012?
There was a problem hiding this comment.
Because reboot consume too much time, so I don't create a new test for it, and want to leverage the reboot-cause history generated by them to test it.
can we add an version check when version is before 202012, skip the test. Is it ok?
wangxin
approved these changes
Sep 16, 2021
sujinmkang
approved these changes
Sep 16, 2021
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
…est_reboot.py (sonic-net#4270) This is to add test case in sonic-mgmt/tests/platform_tests/test_reboot.py to cover new feature reboot-cause history introduced in sonic-net/SONiC#669. Example: show reboot-cause history Name Cause Time User Comment ------------------- ------------- ------------------------------- ------ --------- 2021_09_09_14_15_13 Power Loss () N/A N/A N/A 2021_09_09_14_06_17 reboot Thu 09 Sep 2021 02:05:17 PM UTC admin N/A 2021_09_09_13_59_11 Watchdog () N/A N/A N/A 2021_09_09_13_52_13 Power Loss () N/A N/A N/A 2021_09_09_13_45_18 warm-reboot Thu 09 Sep 2021 01:44:14 PM UTC admin N/A 2021_09_09_13_37_58 fast-reboot Thu 09 Sep 2021 01:37:09 PM UTC admin N/A 2021_09_09_13_30_52 soft-reboot Thu 09 Sep 2021 01:30:24 PM UTC admin N/A 2021_09_09_13_24_17 reboot Thu 09 Sep 2021 01:23:17 PM UTC admin N/A What is the motivation for this PR? In order to verify reboot-cause history function, add new checker for "show reboot-cause history" into reboot tests How did you do it? Add one new function of check_reboot_cause_history in sonic-mgmt/tests/platform_tests/test_reboot.py. In test_reboot.py, there are 8 different reboot tests. In order to save test execution time, we leverage the reboot-cause history generated by them to test it. 1. Verify the reboot-cause history title 2. Verify reboot-cause output are sorted in reverse chronological order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Since adding the feature(sonic-net/SONiC#669) of show reboot-cause history, so integrate "show reboot-cause history" into sonic-mgmt/tests/platform_tests/test_reboot.py.
e.g.
Type of change
Back port request
Approach
What is the motivation for this PR?
In order to verify reboot-cause history function, add new checker for "show reboot-cause history" into reboot tests
How did you do it?
Add one new function of check_reboot_cause_history in sonic-mgmt/tests/platform_tests/test_reboot.py.
In test_reboot.py, there are 8 different reboot tests. In order to save test execution time, we leverage the reboot-cause history generated by them to test it.
How did you verify/test it?
run test_reboot.py
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation
sonic-net/SONiC#669