[Bugfix] Bugfix for getting maximum matching length of conditional mark. #14515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xwjiang-ms
approved these changes
Sep 11, 2024
yutongzhang-microsoft
deleted the
yutongzhang/bugfix_conditional_mark
branch
This was referenced Sep 12, 2024
hdwhdw
pushed a commit
to hdwhdw/sonic-mgmt
that referenced
this pull request
Sep 20, 2024
…rk. (sonic-net#14515) Description of PR We changed the matching rule of conditional mark in PR sonic-net#14395. There is a bug when getting the maximum matching length. In this PR, we fix this bug. Approach What is the motivation for this PR? We changed the matching rule of conditional mark in PR sonic-net#14395. There is a bug when getting the maximum matching length. In this PR, we fix this bug. co-authorized by: jianquanye@microsoft.com
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
…rk. (sonic-net#14515) Description of PR We changed the matching rule of conditional mark in PR sonic-net#14395. There is a bug when getting the maximum matching length. In this PR, we fix this bug. Approach What is the motivation for this PR? We changed the matching rule of conditional mark in PR sonic-net#14395. There is a bug when getting the maximum matching length. In this PR, we fix this bug. co-authorized by: jianquanye@microsoft.com
|
@yutongzhang-microsoft PR conflicts with 202405 branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
We changed the matching rule of conditional mark in PR #14395. There is a bug when getting the maximum matching length. In this PR, we fix this bug.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
We changed the matching rule of conditional mark in PR #14395. There is a bug when getting the maximum matching length. In this PR, we fix this bug.
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation