[Mellanox] Update test_exceeding_headroom due to adding checker when enabling SHP #14479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heck when enabling shared headroom
stephenxs
approved these changes
Sep 9, 2024
11 tasks
|
/azpw run Azure.sonic-mgmt |
|
/AzurePipelines run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@kperumalbfn Can you help review? |
|
Hi @kperumalbfn, Can you help review it? |
liat-grozovik
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Previously, when enabling SHP there is no checker even if the accumulative headroom(shared headroom) of a port exceeds the maximum threshold. Currently, we have added the checker for mellanox device, so we update the existing case test_exceeding_headroom to cover the scenarios enabling SHP.
The relevant PR: sonic-net/sonic-swss#3272
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Add new case to cover new scenarios enabling SHP
How did you do it?
Update test_exceeding_headroom
How did you verify/test it?
Run test_exceeding_headroom on Mellanox device
Any platform specific information?
Mellanox
Supported testbed topology if it's a new test case?
Any
Documentation