Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test gap] add a new test case for bgp session check #14015

Merged
merged 8 commits into from
Aug 14, 2024

Conversation

lipxu
Copy link
Contributor

@lipxu lipxu commented Aug 7, 2024

Description of PR

Summary:
Fixes # (issue)
26557087

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

FRR issue sonic-net/sonic-buildimage#12380
Verify the bgp sessions' status

How did you do it?

1: check all bgp sessions are up
2: inject failure, shutdown fanout physical interface or neighbor port
4: do the test, reset bgp or swss or do the reboot
5: Verify all bgp sessions are up

How did you verify/test it?

Run the test case

Any platform specific information?

Supported testbed topology if it's a new test case?

T0,T1

Documentation

Copy link
Contributor

@yutongzhang-microsoft yutongzhang-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @lipxu, have you tested this script on kvm testbed? If this script can run on kvm, please add it into corresponding PR checker.

@lipxu
Copy link
Contributor Author

lipxu commented Aug 7, 2024

Hi, @lipxu, have you tested this script on kvm testbed? If this script can run on kvm, please add it into corresponding PR checker.

Not yet, but the script includes a warm-reboot operation, not sure whether it is supported on kvm.
Could you suggest a quick way to verify it? thanks a lot

nbrhosts[neighbor_name]['host'].shutdown(neighbor_port)
time.sleep(1)

duthost.shell('show ip bgp summary', module_ignore_errors=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to verify the bgp sessions are down here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lolyu , will add a check here.

@yutongzhang-microsoft
Copy link
Contributor

yutongzhang-microsoft commented Aug 8, 2024

ncludes a warm-reboot operation, not sure whethe

Hi, @lipxu , can you test locally first? And then, you can add this script into onboarding T0 and T1 PR checker https://github.com/sonic-net/sonic-mgmt/blob/master/.azure-pipelines/pr_test_scripts.yaml#L343

@lipxu
Copy link
Contributor Author

lipxu commented Aug 8, 2024

ncludes a warm-reboot operation, not sure whethe

Hi, @lipxu , can you test locally first? And then, you can add this script into onboarding T0 and T1 PR checker https://github.com/sonic-net/sonic-mgmt/blob/master/.azure-pipelines/pr_test_scripts.yaml#L343

This case includes fanout interface operation (shutdown/no shutdown), and warm-reboot which not supported on kvm yet. will skip it on kvm.

@lipxu
Copy link
Contributor Author

lipxu commented Aug 9, 2024

ncludes a warm-reboot operation, not sure whethe

Hi, @lipxu , can you test locally first? And then, you can add this script into onboarding T0 and T1 PR checker https://github.com/sonic-net/sonic-mgmt/blob/master/.azure-pipelines/pr_test_scripts.yaml#L343

Hi, @yutongzhang-microsoft added the test case into the PR test list.

Copy link
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit 0a7e113 into sonic-net:master Aug 14, 2024
16 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Aug 14, 2024
What is the motivation for this PR?
FRR issue sonic-net/sonic-buildimage#12380
Verify the bgp sessions' status

How did you do it?
1: check all bgp sessions are up
2: inject failure, shutdown fanout physical interface or neighbor port
4: do the test, reset bgp or swss or do the reboot
5: Verify all bgp sessions are up
How did you verify/test it?
Run the test case

Any platform specific information?
Supported testbed topology if it's a new test case?
T0,T1
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #14105

mssonicbld pushed a commit that referenced this pull request Aug 14, 2024
What is the motivation for this PR?
FRR issue sonic-net/sonic-buildimage#12380
Verify the bgp sessions' status

How did you do it?
1: check all bgp sessions are up
2: inject failure, shutdown fanout physical interface or neighbor port
4: do the test, reset bgp or swss or do the reboot
5: Verify all bgp sessions are up
How did you verify/test it?
Run the test case

Any platform specific information?
Supported testbed topology if it's a new test case?
T0,T1
eddieruan-alibaba pushed a commit to eddieruan-alibaba/sonic-mgmt that referenced this pull request Sep 4, 2024
What is the motivation for this PR?
FRR issue sonic-net/sonic-buildimage#12380
Verify the bgp sessions' status

How did you do it?
1: check all bgp sessions are up
2: inject failure, shutdown fanout physical interface or neighbor port
4: do the test, reset bgp or swss or do the reboot
5: Verify all bgp sessions are up
How did you verify/test it?
Run the test case

Any platform specific information?
Supported testbed topology if it's a new test case?
T0,T1
arista-hpandya pushed a commit to arista-hpandya/sonic-mgmt that referenced this pull request Oct 2, 2024
What is the motivation for this PR?
FRR issue sonic-net/sonic-buildimage#12380
Verify the bgp sessions' status

How did you do it?
1: check all bgp sessions are up
2: inject failure, shutdown fanout physical interface or neighbor port
4: do the test, reset bgp or swss or do the reboot
5: Verify all bgp sessions are up
How did you verify/test it?
Run the test case

Any platform specific information?
Supported testbed topology if it's a new test case?
T0,T1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants