-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test gap] add a new test case for bgp session check #14015
[test gap] add a new test case for bgp session check #14015
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @lipxu, have you tested this script on kvm testbed? If this script can run on kvm, please add it into corresponding PR checker.
Not yet, but the script includes a warm-reboot operation, not sure whether it is supported on kvm. |
nbrhosts[neighbor_name]['host'].shutdown(neighbor_port) | ||
time.sleep(1) | ||
|
||
duthost.shell('show ip bgp summary', module_ignore_errors=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to verify the bgp sessions are down here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lolyu , will add a check here.
Hi, @lipxu , can you test locally first? And then, you can add this script into onboarding T0 and T1 PR checker https://github.com/sonic-net/sonic-mgmt/blob/master/.azure-pipelines/pr_test_scripts.yaml#L343 |
This case includes fanout interface operation (shutdown/no shutdown), and warm-reboot which not supported on kvm yet. will skip it on kvm. |
Hi, @yutongzhang-microsoft added the test case into the PR test list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is the motivation for this PR? FRR issue sonic-net/sonic-buildimage#12380 Verify the bgp sessions' status How did you do it? 1: check all bgp sessions are up 2: inject failure, shutdown fanout physical interface or neighbor port 4: do the test, reset bgp or swss or do the reboot 5: Verify all bgp sessions are up How did you verify/test it? Run the test case Any platform specific information? Supported testbed topology if it's a new test case? T0,T1
Cherry-pick PR to 202405: #14105 |
What is the motivation for this PR? FRR issue sonic-net/sonic-buildimage#12380 Verify the bgp sessions' status How did you do it? 1: check all bgp sessions are up 2: inject failure, shutdown fanout physical interface or neighbor port 4: do the test, reset bgp or swss or do the reboot 5: Verify all bgp sessions are up How did you verify/test it? Run the test case Any platform specific information? Supported testbed topology if it's a new test case? T0,T1
What is the motivation for this PR? FRR issue sonic-net/sonic-buildimage#12380 Verify the bgp sessions' status How did you do it? 1: check all bgp sessions are up 2: inject failure, shutdown fanout physical interface or neighbor port 4: do the test, reset bgp or swss or do the reboot 5: Verify all bgp sessions are up How did you verify/test it? Run the test case Any platform specific information? Supported testbed topology if it's a new test case? T0,T1
What is the motivation for this PR? FRR issue sonic-net/sonic-buildimage#12380 Verify the bgp sessions' status How did you do it? 1: check all bgp sessions are up 2: inject failure, shutdown fanout physical interface or neighbor port 4: do the test, reset bgp or swss or do the reboot 5: Verify all bgp sessions are up How did you verify/test it? Run the test case Any platform specific information? Supported testbed topology if it's a new test case? T0,T1
Description of PR
Summary:
Fixes # (issue)
26557087
Type of change
Back port request
Approach
What is the motivation for this PR?
FRR issue sonic-net/sonic-buildimage#12380
Verify the bgp sessions' status
How did you do it?
How did you verify/test it?
Run the test case
Any platform specific information?
Supported testbed topology if it's a new test case?
T0,T1
Documentation