Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[container hardening] include more containers to test case #11461

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

maipbui
Copy link
Contributor

@maipbui maipbui commented Feb 1, 2024

Description of PR

Summary: Add more containers to container hardening test case
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Mai Bui <maibui@microsoft.com>
Signed-off-by: Mai Bui <maibui@microsoft.com>
@maipbui maipbui requested a review from qiluo-msft February 1, 2024 02:30
@maipbui maipbui marked this pull request as ready for review February 1, 2024 02:30

pytestmark = [
pytest.mark.topology('any'),
]

logger = logging.getLogger(__name__)

NO_PRIVILEGED_CONTAINERS = [
Copy link
Contributor

@qiluo-msft qiluo-msft Feb 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NO_PRIVILEGED_CONTAINERS

Could you use a PRIVILEGED_CONTAINERS list? This list initial value may change in future. #Closed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, not sure if it addresses what you're asking, please help re-review

Signed-off-by: Mai Bui <maibui@microsoft.com>
@qiluo-msft qiluo-msft merged commit b49089e into sonic-net:master Feb 5, 2024
13 checks passed
@maipbui maipbui deleted the improve_ctnr_hardening branch February 5, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants