Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:10986] [syslog] enable/disable syslog rate limit feature in fixture #11315

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

mssonicbld
Copy link
Collaborator

Depending on sonic-net/sonic-buildimage#17458

Description of PR

Feature syslog rate limit has been disabled by default to avoid consume CPU cycles during warm / fast reboot. There are new CLIs to enable/disable it. The PR is to automatically enable it before syslog rate limit test and disable it after.

Summary:
In fixture "restore_rate_limit", enable the feature at beginning, disable the feature at the end.

Type of change

[ ] Bug fix
[ ] Testbed and Framework(new/improvement)
[x] Test case(new/improvement)

Back port request

[ ] 201911
[ ] 202012
[ ] 202205
[x] 202305

Approach

In fixture "restore_rate_limit", enable the feature at beginning, disable the feature at the end.

What is the motivation for this PR?

Align test code with production code change

How did you do it?

In fixture "restore_rate_limit", enable the feature at beginning, disable the feature at the end.

How did you verify/test it?

Run test case on local setup, all passed

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

N/A

Documentation

…et#10986)

Feature syslog rate limit has been disabled by default to avoid consume CPU cycles during warm / fast reboot. There are new CLIs to enable/disable it. The PR is to automatically enable it before syslog rate limit test and disable it after.

Summary:
In fixture "restore_rate_limit", enable the feature at beginning, disable the feature at the end.

Change-Id: I61545db602d579fa0f337686427235c6d04998c7
@mssonicbld
Copy link
Collaborator Author

Original PR: #10986

@mssonicbld mssonicbld merged commit d578043 into sonic-net:202305 Jan 18, 2024
12 checks passed
@mssonicbld mssonicbld deleted the cherry/202305/10986 branch February 4, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants