Add Serial Number check test case. #11092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xincunli-sonic the summary of this PR says this is related to reboot? How? |
keboliu
reviewed
Dec 20, 2023
updated, Thanks! |
Output get_serial_no_cmd instead of cmd.
prgeor
approved these changes
Dec 22, 2023
bingwang-ms
approved these changes
Jan 3, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Feb 1, 2024
* Add Serial Number check test case.
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Feb 1, 2024
* Add Serial Number check test case.
|
Cherry-pick PR to 202205: #11522 |
|
Cherry-pick PR to 202305: #11523 |
This was referenced Feb 1, 2024
mssonicbld
pushed a commit
that referenced
this pull request
Feb 1, 2024
* Add Serial Number check test case.
mssonicbld
pushed a commit
that referenced
this pull request
Feb 1, 2024
* Add Serial Number check test case.
mssonicbld
added
Included in 202305 branch
and removed
Created PR to 202305 branch
labels
mssonicbld
added
Included in 202205 branch
and removed
Created PR to 202205 branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
test_platform_serial_notest case that can help identifing the serial no. mismatching issue.Type of change
Approach
Use
decode-syseeprom -sto compare with modeled inventory information.What is the motivation for this PR?
We were hitting complains that prod devices had mismatch serial number, later, we have this fix, now we need align this gap by adding this test case.
How did you do it?
Compare
decode-syseeprom -soutput with inventory data.How did you verify/test it?
Ran the test in multiple platform lab devices, which shows passed.
Any platform specific information?
This is common test issue.
Signed-off-by: Xincun Li xincun.li@microsoft.com