Make acl test more robust in checking syslog #10271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…here. Add delay to make sure ACL is applied before checking syslog.
wenyiz2021
reviewed
Oct 9, 2023
wenyiz2021
approved these changes
Oct 11, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Nov 2, 2023
…here. (sonic-net#10271) Add delay to make sure ACL is applied before checking syslog.
|
Cherry-pick PR to 202305: #10593 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Nov 2, 2023
…here. (sonic-net#10271) Add delay to make sure ACL is applied before checking syslog.
5 tasks
|
Cherry-pick PR to 202205: #10594 |
5 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Nov 2, 2023
…here. (#10271) Add delay to make sure ACL is applied before checking syslog.
mssonicbld
added
Included in 202305 branch
and removed
Created PR to 202305 branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Nov 5, 2023
…here. (#10271) Add delay to make sure ACL is applied before checking syslog.
mssonicbld
added
Included in 202205 branch
and removed
Created PR to 202205 branch
labels
8 tasks
yejianquan
pushed a commit
that referenced
this pull request
Jul 26, 2024
Description of PR Drop counters test is flaky in checking syslogs. The logs check keeps failing on T2 topo even though the target log was there. Adding a delay before checking syslog can prevent this from happening. (We have made similar changes to ACL test before: #10271) Summary: Fixes # (issue) Microsoft ADO 28740493 Approach What is the motivation for this PR? How did you do it? How did you verify/test it? I ran the updated test and can confirm it's passing now. co-authorized by: jianquanye@microsoft.com
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 26, 2024
…t#13806) Description of PR Drop counters test is flaky in checking syslogs. The logs check keeps failing on T2 topo even though the target log was there. Adding a delay before checking syslog can prevent this from happening. (We have made similar changes to ACL test before: sonic-net#10271) Summary: Fixes # (issue) Microsoft ADO 28740493 Approach What is the motivation for this PR? How did you do it? How did you verify/test it? I ran the updated test and can confirm it's passing now. co-authorized by: jianquanye@microsoft.com
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jul 26, 2024
Description of PR Drop counters test is flaky in checking syslogs. The logs check keeps failing on T2 topo even though the target log was there. Adding a delay before checking syslog can prevent this from happening. (We have made similar changes to ACL test before: #10271) Summary: Fixes # (issue) Microsoft ADO 28740493 Approach What is the motivation for this PR? How did you do it? How did you verify/test it? I ran the updated test and can confirm it's passing now. co-authorized by: jianquanye@microsoft.com
eddieruan-alibaba
pushed a commit
to eddieruan-alibaba/sonic-mgmt
that referenced
this pull request
Sep 4, 2024
…t#13806) Description of PR Drop counters test is flaky in checking syslogs. The logs check keeps failing on T2 topo even though the target log was there. Adding a delay before checking syslog can prevent this from happening. (We have made similar changes to ACL test before: sonic-net#10271) Summary: Fixes # (issue) Microsoft ADO 28740493 Approach What is the motivation for this PR? How did you do it? How did you verify/test it? I ran the updated test and can confirm it's passing now. co-authorized by: jianquanye@microsoft.com
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
…t#13806) Description of PR Drop counters test is flaky in checking syslogs. The logs check keeps failing on T2 topo even though the target log was there. Adding a delay before checking syslog can prevent this from happening. (We have made similar changes to ACL test before: sonic-net#10271) Summary: Fixes # (issue) Microsoft ADO 28740493 Approach What is the motivation for this PR? How did you do it? How did you verify/test it? I ran the updated test and can confirm it's passing now. co-authorized by: jianquanye@microsoft.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acl test is flaky in checking syslogs. Test failed even the log was there. Add delay to make sure ACL is applied before checking syslog.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation