Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macsec skip in 202305 #10246

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

judyjoseph
Copy link
Contributor

@judyjoseph judyjoseph commented Oct 6, 2023

What is the motivation for this PR?

Following what as done in master and 202205 for macsec type7 changes

Add the remove first and later revert REF: #10132

MSFT ADO : 25261395

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Pterosaur and others added 2 commits October 6, 2023 16:04
Approach
What is the motivation for this PR?
Due to the TYPE 7 changing for MACsec, MACsec tests break the submodule,sonic-swss/sonic-sairedis, updating.

How did you do it?
Disable MACsec tests in the pr_test script.

How did you verify/test it?
Check Azp

co-authorized by: jianquanye@microsoft.com
@judyjoseph
Copy link
Contributor Author

judyjoseph commented Oct 9, 2023

@StormLiangMS could you approve and merge this PR, ADO updated in PR comments.

Copy link
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit c27145e into sonic-net:202305 Oct 19, 2023
12 checks passed
@judyjoseph judyjoseph deleted the remove_macsec_skip_202305 branch October 19, 2023 02:41
judyjoseph added a commit to judyjoseph/sonic-mgmt that referenced this pull request Nov 21, 2023
StormLiangMS pushed a commit that referenced this pull request Nov 22, 2023
What is the motivation for this PR?
Revert the macsec test skip PR, done earlier via PR #10246

How did you do it?
How did you verify/test it?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants