[Cherry-pick] Adding COUNTER_MARGIN to Ingress drop counters …#9896 #10210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for qos tests (sonic-net#9896) * Qos_LossyQueueTest fix_adding COUNTER MARGIN * Adding COUNTER_MARGIN to qos PFCXonTest * Adding COUNTER_MARGIN to qos PFCTest * Flake8 fixes * testQosSaiPFCXoffLimit updated with correct check * Conditional check corrected for LossyQueueTest * flake8 fix
judyjoseph
approved these changes
Oct 3, 2023
|
@vmittal-msft please help review, |
|
@vmittal-msft, could you please review this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…for qos tests (#9896)
Qos_LossyQueueTest fix_adding COUNTER MARGIN
Adding COUNTER_MARGIN to qos PFCXonTest
Adding COUNTER_MARGIN to qos PFCTest
testQosSaiPFCXoffLimit updated with correct check
Conditional check corrected for LossyQueueTest
Description of PR
Master branch PR #9896
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation