[action] [PR:9301] [Dual-Tor][Mellanox]Use GRE type 0x8949 when it is Nvidia platform in the test_encap_with_mirror_session test. #10175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
The test case test_encap_with_mirror_session in tests/dualtor/test_ipinip.py uses the GRE type 1234(0x04d2) when configuring the mirror session.
But for Nvidia platforms, we only support the GRE type 35145(0x8949) for mirroring and this is already noted in our release notes.
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix the GRE type test issue in test_encap_with_mirror_session test.
How did you do it?
Use GRE type 0x8949 when it is Nvidia platform.
How did you verify/test it?
Run the test on 4600C dualtor setup, it passed.
Any platform specific information?
This change is only for Nvidia platforms.
Supported testbed topology if it's a new test case?
Documentation