Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test Gap] ECMP over Vxlan with BGP advertising. #5581

Open
StormLiangMS opened this issue Apr 29, 2022 · 2 comments
Open

[Test Gap] ECMP over Vxlan with BGP advertising. #5581

StormLiangMS opened this issue Apr 29, 2022 · 2 comments
Assignees
@siqbal1986
Labels
P1 Test gap

Comments

@StormLiangMS
Copy link
Collaborator

Scope:

2.8.3 BGP advertising

The below cases are executed first for IPv4 and repeat the same for IPv6.

Step Goal Expected results
Create a tunnel route and advertise the tunnel route to all neighbor without community id BGP ALL BGP neighbors can recieve the advertised BGP routes
Create a tunnel route and advertise the tunnel route to all neighbor with community id BGP ALL BGP neighbors can recieve the advertised BGP routes with community id
Update a tunnel route and advertise the tunnel route to all neighbor with new community id BGP ALL BGP neighbors can recieve the advertised BGP routes with new community id
Create a tunnel route and advertise the tunnel route to all neighbor with BGP profile, but create the profile later BGP ALL BGP neighbors can recieve the advertised BGP routes without community id first, after the profile table created, the community id would be added and all BGP neighbors can recieve this update and associate the community id with the route
Delete a tunnel route BGP ALL BGP neighbors can remove the previously advertised BGP routes
Create 4k tunnel routes and advertise all tunnel routes to all neighbor with community id BGP scale ALL BGP neighbors can recieve 4k advertised BGP routes with community id and record the time
Updat BGP_PROFILE_TABLE with new community id for 4k tunnel routes and advertise all tunnel routes to all neighbor with new community id BGP scale ALL BGP neighbors can recieve 4k advertised BGP routes with new community id and record the time
@StormLiangMS StormLiangMS self-assigned this Apr 29, 2022
@StormLiangMS StormLiangMS mentioned this issue Apr 29, 2022
Merged
6 tasks
StormLiangMS added a commit to sonic-net/sonic-buildimage that referenced this issue May 19, 2022
@StormLiangMS
[bgpcfgd] ECMP overlay VxLan with BGP support (#10716)
0cc9fdc 
Why I did it
https://github.com/Azure/SONiC/blob/master/doc/vxlan/Overlay%20ECMP%20with%20BFD.md
From the design, need to advertise the route with community string, the PR is to implement this.

How I did it
To use the route-map as the profile for the community string, all advertised routes can be associated with one route-map.
Add one file, mangers_rm.py, which is to add/update/del the route-map. Modified the managers_advertise_rt.py file to associate profile with IP route.

The route-map usage is very flexible, by this PR, we only support one fixed usage to add community string for route to simplify this design.

How to verify it
Implement new unit tests for mangers_rm.py and updated unit test for managers_advertise_rt.py.
Manually verified the test case in the test plan section, will add testcase in sonic-mgmt later. sonic-net/sonic-mgmt#5581
qiluo-msft pushed a commit to sonic-net/sonic-buildimage that referenced this issue May 24, 2022
@StormLiangMS @qiluo-msft
[bgpcfgd] ECMP overlay VxLan with BGP support (#10716)
35c9bec 
Why I did it
https://github.com/Azure/SONiC/blob/master/doc/vxlan/Overlay%20ECMP%20with%20BFD.md
From the design, need to advertise the route with community string, the PR is to implement this.

How I did it
To use the route-map as the profile for the community string, all advertised routes can be associated with one route-map.
Add one file, mangers_rm.py, which is to add/update/del the route-map. Modified the managers_advertise_rt.py file to associate profile with IP route.

The route-map usage is very flexible, by this PR, we only support one fixed usage to add community string for route to simplify this design.

How to verify it
Implement new unit tests for mangers_rm.py and updated unit test for managers_advertise_rt.py.
Manually verified the test case in the test plan section, will add testcase in sonic-mgmt later. sonic-net/sonic-mgmt#5581
@siqbal1986
Copy link
Contributor

@StormLiangMS The following is an invalid test case

Create a tunnel route and advertise the tunnel route to all neighbor with BGP profile, but create the profile later | BGP | ALL BGP neighbors can recieve the advertised BGP routes without community id first, after the profile table created, the community id would be added and all BGP neighbors can recieve this update and associate the community id with the route

This is because if we create a route with a profile name but that profile itself doent exist. the route would not be advertised. however if we do create the profile later, it would be advertised.
we cna also advertise a route without a profile but advetising with a non existing profile is not a correct scenario.

@siqbal1986
Copy link
Contributor

#14666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@siqbal1986 siqbal1986

Labels
P1 Test gap
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@siqbal1986 @StormLiangMS