Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query Parameters Pruning API and Tests #105

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Query Parameters Pruning API and Tests #105

merged 2 commits into from
Oct 11, 2023

Conversation

a-barboza
Copy link
Contributor

  • Pruning API used by subtree transformers for Query Parameters.
  • Tests. ( Only ACL is enabled currently, since the others need support from the corresponding feature teams )
  • Updated the hooks to invoke the pruning API.
  • The GET request cancelling context parameter is passed to some of the pruning functions, but is not implemented since that is appearing in a separate PR

amrutasali
amrutasali suggested changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@amrutasali amrutasali left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in xlate_xfmr_handler.go in addition to the "inParams.pruneDone = new(bool)" the check "&& !(*inParams.pruneDone) " needs to be at line 52

@a-barboza
Query Parameters Pruning API and Tests
43cb7ef 
- Pruning API used by subtree transformers for Query Parameters.
- Tests. ( Only ACL is enabled currently, since the others need
  support from the corresponding feature teams )
- Updated the hooks to invoke the pruning API.
- The GET request cancelling context parameter is passed to some
  of the pruning functions, but is not implemented since that is appearing
  in a separate PR
@a-barboza
Query Parameters Pruning API and Tests.
d8e665e 
    Fix for missing pruneDone check.
@anand-kumar-subramanian anand-kumar-subramanian merged commit a16b59b into sonic-net:master Oct 11, 2023
@adyeung adyeung mentioned this pull request Oct 12, 2023
Closed
@ranjinidn ranjinidn mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrutasali amrutasali amrutasali approved these changes

@kwangsuk kwangsuk kwangsuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@a-barboza @kwangsuk @amrutasali @anand-kumar-subramanian