Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[linkmgrd] update README, set coding style guidance #15

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

yxieca
Copy link
Contributor

@yxieca yxieca commented Jan 4, 2022

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • New feature
  • Doc/Design
  • Unit test

Approach

What is the motivation for this PR?

Update README. Setting some simple guidance for coding style.

Signed-off-by: Ying Xie ying.xie@microsoft.com

@yxieca yxieca marked this pull request as draft January 4, 2022 23:36
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@yxieca yxieca marked this pull request as ready for review January 4, 2022 23:59
@yxieca yxieca requested review from lguohan, lolyu and zjswhhh January 5, 2022 00:00
Copy link
Contributor

@zjswhhh zjswhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lolyu lolyu merged commit 259c358 into sonic-net:master Jan 6, 2022
@yxieca yxieca deleted the coding branch January 6, 2022 03:09
yxieca added a commit that referenced this pull request Jan 14, 2022
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
zjswhhh pushed a commit to zjswhhh/sonic-linkmgrd that referenced this pull request Jan 19, 2022
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
zjswhhh pushed a commit to zjswhhh/sonic-linkmgrd that referenced this pull request Jan 24, 2022
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants