Added Support to render Feature Table using Device running metadata. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added support to render 'has_asic_scope' field of Feature Table. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
This was referenced Aug 19, 2022
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
|
/azp run |
|
Commenter does not have sufficient privileges for PR 14 in repo sonic-net/sonic-host-services |
|
/azp run sonic-net.sonic-host-services |
|
Commenter does not have sufficient privileges for PR 14 in repo sonic-net/sonic-host-services |
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
|
@arlakshm can you please help review this. |
|
@abdosi , can you update the branch ? |
arlakshm
reviewed
Sep 9, 2022
| .format(feature.name, feature_suffixes[-1])) | ||
| self.set_feature_state(feature, self.FEATURE_STATE_FAILED) | ||
| return | ||
| self._config_db.mod_entry('FEATURE', feature_config.name, {'has_per_asic_scope': str(feature_config.has_per_asic_scope)}) |
There was a problem hiding this comment.
The host config_db will have has_per_asic_scope as failed but the config_db for the asic will have them as enabled? should we update that as well to avoid confusion
There was a problem hiding this comment.
@arlakshm yes, that we can do later if needed. Currently also other fields of this table are not same between host and asic.
I think that change will be coming as part of separate PR may be where we needed to update (ex:macsec feature state) that need be updated in asic db also. In that PR we can update this field also.
arlakshm
approved these changes
Sep 22, 2022
abdosi
added a commit
to abdosi/sonic-buildimage
that referenced
this pull request
Nov 6, 2022
into 202205 branch Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
abdosi
added a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Nov 8, 2022
Cherry-pick of sonic-net/sonic-host-services#14 in 202205 branch
ganglyu
pushed a commit
that referenced
this pull request
Feb 13, 2023
Cherry-pick of #14 in 202205 branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
Added Support to render Feature Table using Device running metadata
Also added support to render 'has_asic_scope' field of Feature Table.
Why I did:
Details: sonic-net/sonic-buildimage#11796
How I verify:
Manual Verification
UT added including multi-asic,