[Mellanox] Allow user to set LED to orange #9259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sujinmkang @prgeor would you please help to review this PR? It's a bug fix to Nvidia platform API implementation. |
liat-grozovik
approved these changes
Nov 22, 2021
sujinmkang
reviewed
Nov 22, 2021
| @@ -62,7 +62,9 @@ def mock_write_file(file_path, content, **kwargs): | |||
| assert obj.set_status_led(Led.STATUS_LED_COLOR_GREEN) is True | |||
| assert obj.get_status_led() == Led.STATUS_LED_COLOR_GREEN | |||
| mock_file_content[physical_led.get_green_led_path()] = Led.LED_OFF | |||
| assert obj.set_status_led(Led.STATUS_LED_COLOR_ORANGE) is False | |||
| assert obj.set_status_led(Led.STATUS_LED_COLOR_ORANGE) is True | |||
| assert obj.get_status_led() == Led.STATUS_LED_COLOR_RED | |||
There was a problem hiding this comment.
Why not Led.STATUS_LED_COLOR_ORANGE but Led.STATUS_LED_COLOR_RED?
There was a problem hiding this comment.
We might display led color in CLI by calling get_status_led, and we want user to understand green=OK, red=Not OK. Different platform might support different LED color, this is to unify the behavior.
There was a problem hiding this comment.
@Junchao-Mellanox Got it. I found the get_status() returns STATUS_LED_COLOR_RED for both RED and ORANGE LED.
|
No clean cherry-pick for 202012 and 202106, need separate PRs. |
|
@sujinmkang any further comment or we can move forward and merge? |
sujinmkang
approved these changes
Nov 30, 2021
Junchao-Mellanox
added
the
Request for 202111 Branch
keboliu
approved these changes
Dec 3, 2021
Junchao-Mellanox
added a commit
to Junchao-Mellanox/sonic-buildimage
that referenced
this pull request
Dec 13, 2021
Why I did it Nvidia platform API does not support set LED to orange How I did it Allow user to set LED to orange How to verify it Added unit test Manual test Conflicts: platform/mellanox/mlnx-platform-api/sonic_platform/led.py platform/mellanox/mlnx-platform-api/tests/test_led.py
5 tasks
5 tasks
Junchao-Mellanox
added a commit
to Junchao-Mellanox/sonic-buildimage
that referenced
this pull request
Dec 13, 2021
Why I did it Nvidia platform API does not support set LED to orange How I did it Allow user to set LED to orange How to verify it Added unit test Manual test
This was referenced Dec 13, 2021
qiluo-msft
pushed a commit
that referenced
this pull request
Dec 14, 2021
Backport #9259 to 202012 #### Why I did it Nvidia platform API does not support set LED to orange. #### How I did it Allow user to set LED to orange #### How to verify it Manual test
liat-grozovik
pushed a commit
that referenced
this pull request
Dec 14, 2021
judyjoseph
pushed a commit
that referenced
this pull request
Dec 27, 2021
Why I did it Nvidia platform API does not support set LED to orange How I did it Allow user to set LED to orange How to verify it Added unit test Manual test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Nvidia platform API does not support set LED to orange
How I did it
Allow user to set LED to orange
How to verify it
Added unit test
Manual test
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)