[Mellanox] Fan speed should not be 100% when PSU is powered off #9258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@sujinmkang could you please take a look when you have time? |
keboliu
approved these changes
Nov 19, 2021
liat-grozovik
approved these changes
Nov 22, 2021
sujinmkang
approved these changes
Nov 22, 2021
|
We can clean cherry-pick this to 202106/202012, we need separate PR for 201911. |
|
Hi @judyjoseph , could you please cherry-pick to 202106. |
Junchao-Mellanox
added a commit
to Junchao-Mellanox/sonic-buildimage
that referenced
this pull request
Nov 25, 2021
…c-net#9258) - Why I did it When PSU is powered off, the PSU is still on the switch and the air flow is still the same. In this case, it is not necessary to set FAN speed to 100%. - How I did it When PSU is powered of, don't treat it as absent. - How to verify it Adjust existing unit test case Add new case in sonic-mgmt Conflicts: platform/mellanox/mlnx-platform-api/sonic_platform/thermal_infos.py
5 tasks
qiluo-msft
pushed a commit
that referenced
this pull request
Dec 1, 2021
- Why I did it When PSU is powered off, the PSU is still on the switch and the air flow is still the same. In this case, it is not necessary to set FAN speed to 100%. - How I did it When PSU is powered of, don't treat it as absent. - How to verify it Adjust existing unit test case Add new case in sonic-mgmt
judyjoseph
pushed a commit
that referenced
this pull request
Dec 1, 2021
- Why I did it When PSU is powered off, the PSU is still on the switch and the air flow is still the same. In this case, it is not necessary to set FAN speed to 100%. - How I did it When PSU is powered of, don't treat it as absent. - How to verify it Adjust existing unit test case Add new case in sonic-mgmt
abdosi
pushed a commit
that referenced
this pull request
Dec 8, 2021
… (#9380) Backport #9258 to 201911 Why I did it When PSU is powered off, the PSU is still on the switch and the air flow is still the same. In this case, it is not necessary to set FAN speed to 100%. How I did it When PSU is powered of, don't treat it as absent. How to verify it Adjust existing unit test case Add new case in sonic-mgmt Conflicts: platform/mellanox/mlnx-platform-api/sonic_platform/thermal_infos.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
When PSU is powered off, the PSU is still on the switch and the air flow is still the same. In this case, it is not necessary to set FAN speed to 100%.
How I did it
When PSU is powered of, don't treat it as absent.
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)