[hostcfgd] [202012] Fixed the brief blackout in hostcfgd using SubscriberStateTable #9228

vivekrnv · 2021-11-10T23:11:17Z

Why I did it

Backporting #8861 to 202012

How I did it

How to verify it

tests/determine-reboot-cause_test.py .........                                                                                                                       [ 34%]
tests/procdockerstatsd_test.py .                                                                                                                                     [ 38%]
tests/caclmgrd/caclmgrd_dhcp_test.py ......                                                                                                                          [ 61%]
tests/hostcfgd/hostcfgd_test.py ..........                                                                                                                           [100%]

Nov  5 19:37:26.999907 r-lionfish-16 INFO /hostcfgd: ConfigDB connect success
Nov  5 19:37:27.000092 r-lionfish-16 INFO /hostcfgd: KdumpCfg init...
Nov  5 19:37:27.026653 r-lionfish-16 INFO /hostcfgd: Waiting for systemctl to finish initialization
Nov  5 19:37:27.042503 r-lionfish-16 INFO /hostcfgd: systemctl has finished initialization -- proceeding ...
Nov  5 19:37:27.093703 r-lionfish-16 INFO /hostcfgd: Kdump handler...
Nov  5 19:37:27.093924 r-lionfish-16 INFO /hostcfgd: Kdump global configuration update
Nov  5 19:37:27.799234 r-lionfish-16 INFO hostcfgd[234919]: kdump is already disabled
Nov  5 19:37:27.799324 r-lionfish-16 INFO hostcfgd[234919]: Kdump is already disabled
Nov  5 19:37:28.212487 r-lionfish-16 INFO hostcfgd[234961]: Kdump configuration has been updated in the startup configuration
Nov  5 19:37:28.659445 r-lionfish-16 INFO hostcfgd[234976]: Kdump configuration has been updated in the startup configuration
Nov  5 19:37:28.691903 r-lionfish-16 INFO /hostcfgd: Feature swss is enabled and started
Nov  5 19:37:28.711435 r-lionfish-16 INFO /hostcfgd: Feature lldp is enabled and started
Nov  5 19:37:28.730893 r-lionfish-16 INFO /hostcfgd: Running cmd: 'sudo systemctl unmask sflow.service'
Nov  5 19:37:28.754107 r-lionfish-16 INFO hostcfgd[235002]: Removed /etc/systemd/system/sflow.service.
Nov  5 19:37:29.180023 r-lionfish-16 INFO /hostcfgd: Running cmd: 'sudo systemctl enable sflow.service'
Nov  5 19:37:29.193978 r-lionfish-16 INFO hostcfgd[235021]: Created symlink /etc/systemd/system/sonic.target.wants/sflow.service → /lib/systemd/system/sflow.service.
Nov  5 19:37:29.621868 r-lionfish-16 INFO /hostcfgd: Running cmd: 'sudo systemctl start sflow.service'
Nov  5 19:37:30.100161 r-lionfish-16 INFO /hostcfgd: Feature sflow is enabled and started
Nov  5 19:37:30.117581 r-lionfish-16 INFO /hostcfgd: Feature radv is enabled and started
Nov  5 19:37:30.135637 r-lionfish-16 INFO /hostcfgd: Feature teamd is enabled and started
Nov  5 19:37:30.152337 r-lionfish-16 INFO /hostcfgd: Feature what-just-happened is enabled and started
Nov  5 19:37:30.169778 r-lionfish-16 INFO /hostcfgd: Feature snmp is enabled and started
Nov  5 19:37:30.186031 r-lionfish-16 INFO /hostcfgd: Feature telemetry is enabled and started
Nov  5 19:37:30.203852 r-lionfish-16 INFO /hostcfgd: Feature pmon is enabled and started
Nov  5 19:37:30.221953 r-lionfish-16 INFO /hostcfgd: Feature dhcp_relay is enabled and started
Nov  5 19:37:30.239453 r-lionfish-16 INFO /hostcfgd: Feature bgp is enabled and started
Nov  5 19:37:30.256187 r-lionfish-16 INFO /hostcfgd: Feature mgmt-framework is enabled and started
Nov  5 19:37:30.273000 r-lionfish-16 INFO /hostcfgd: Feature database is enabled and started
Nov  5 19:37:30.290031 r-lionfish-16 INFO /hostcfgd: Feature syncd is enabled and started
Nov  5 19:37:30.306905 r-lionfish-16 INFO /hostcfgd: Feature nat is stopped and disabled

Which release branch to backport (provide reason below if selected)

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com> d03ba4fa [202012] [portstat, intfstat] added rates and utilization (sonic-net#1812) 499ad3f4 [config reload] Fix config reload failure due to sonic.target job cancellation (sonic-net#1814) 96d658c2 [202012][sonic installer] Add swap setup support (sonic-net#1815) a9c69702 platform pre-check for reboot in 202012 branch (sonic-net#1788) 0e0478ba Unify the number format in the ourput of portstat and pfcstat in all cases (sonic-net#1795) 2d1e00ed [ecnconfig] Fix exception seen during display and add unit tests (sonic-net#1784) (sonic-net#1789)

…to hostcfg_fix_202012

Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>

vivekrnv · 2021-11-10T23:11:48Z

@qiluo-msft, Can you review this?

qiluo-msft · 2021-11-11T00:03:05Z

src/sonic-host-services/setup.py

@@ -23,13 +23,14 @@
    ],
    setup_requires = [
        'pytest-runner',
-        'wheel'
+        'wheel',


,

This is not in old PR. I am always wondering how do you cherry-pick and resolve conflicts locally. #Closed

I'm sorry. Removed this comma. Cherry pick in this case wasn't possible. As the code for Feature Handler has diverged a lot and the master version has changes related to auto_restart param, i had to rewrite instead

qiluo-msft · 2021-11-11T00:04:53Z

src/sonic-host-services/scripts/hostcfgd

@@ -6,10 +6,13 @@ import ipaddress
 import os
 import subprocess
 import syslog
+import signal
+import sys


Seems like you change order during backport. It will make others backport difficult in general. Could you try minimize new changes during the backport?

Reordered imports and added safe_eval method

Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>

vivekrnv · 2021-11-11T17:51:45Z

/azpw run

mssonicbld · 2021-11-11T17:51:47Z

/AzurePipelines run

azure-pipelines · 2021-11-11T17:51:52Z

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

vivekrnv · 2021-11-12T19:09:43Z

/azpw run

mssonicbld · 2021-11-12T19:09:45Z

/AzurePipelines run

azure-pipelines · 2021-11-12T19:09:50Z

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

vivekrnv · 2021-11-12T23:33:45Z

/azpw run

mssonicbld · 2021-11-12T23:33:46Z

/AzurePipelines run

azure-pipelines · 2021-11-12T23:33:52Z

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

vivekrnv · 2021-11-15T16:46:52Z

/azpw run Azure.sonic-buildimage

mssonicbld · 2021-11-15T16:46:53Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2021-11-15T16:47:07Z

Azure Pipelines successfully started running 1 pipeline(s).

…to hostcfg_fix_202012

dgsudharsan · 2021-11-22T03:15:18Z

@qiluo-msft The pipeline is passing now. Can you please help with the merge?

qiluo-msft · 2021-11-22T18:45:25Z

src/sonic-host-services/scripts/hostcfgd


-    def aaa_handler(self, key, data):
+    def aaa_handler(self, key, op, data):
        self.aaacfg.aaa_update(key, data)


aaa_update

You missed a syslog statement, comparing with #8861

vivekrnv · 2021-11-23T03:30:17Z

@qiluo-msft, CI checks are passing, can you help signoff?

vivekrnv added 5 commits September 13, 2021 16:56

Merge branch '202012' of https://github.com/Azure/sonic-buildimage in…

6aec332

…to hostcfg_fix_202012

Hostcfgd changes related to blackout made

7e930a8

Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>

Missing Import Added

ac18778

Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>

setup.py updated and comments removed

74e6275

Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>

qiluo-msft reviewed Nov 11, 2021

View reviewed changes

vivekrnv and others added 3 commits November 10, 2021 16:05

Removed unnecessary comma

305a322

Added safe_eval and reordered imports

507b0ad

Removed Spaces

f307ac9

Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>

qiluo-msft approved these changes Nov 12, 2021

View reviewed changes

vivekrnv and others added 2 commits November 17, 2021 19:15

Merge branch '202012' of https://github.com/Azure/sonic-buildimage in…

5af7cf0

…to hostcfg_fix_202012

Add the missing op argument for AAA Handler

0452dad

vivekrnv requested a review from qiluo-msft November 21, 2021 21:07

qiluo-msft reviewed Nov 22, 2021

View reviewed changes

Added a syslog entry for AAA table update

e9199ce

qiluo-msft approved these changes Nov 22, 2021

View reviewed changes

qiluo-msft merged commit edd6b84 into sonic-net:202012 Nov 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[hostcfgd] [202012] Fixed the brief blackout in hostcfgd using SubscriberStateTable #9228

[hostcfgd] [202012] Fixed the brief blackout in hostcfgd using SubscriberStateTable #9228

vivekrnv commented Nov 10, 2021

vivekrnv commented Nov 10, 2021

qiluo-msft Nov 11, 2021 •

edited

Loading

vivekrnv Nov 11, 2021 •

edited

Loading

qiluo-msft Nov 11, 2021

vivekrnv Nov 11, 2021

vivekrnv commented Nov 11, 2021

mssonicbld commented Nov 11, 2021

azure-pipelines bot commented Nov 11, 2021

vivekrnv commented Nov 12, 2021

mssonicbld commented Nov 12, 2021

azure-pipelines bot commented Nov 12, 2021

vivekrnv commented Nov 12, 2021

mssonicbld commented Nov 12, 2021

azure-pipelines bot commented Nov 12, 2021

vivekrnv commented Nov 15, 2021

mssonicbld commented Nov 15, 2021

azure-pipelines bot commented Nov 15, 2021

dgsudharsan commented Nov 22, 2021

qiluo-msft Nov 22, 2021

vivekrnv commented Nov 23, 2021

[hostcfgd] [202012] Fixed the brief blackout in hostcfgd using SubscriberStateTable #9228

[hostcfgd] [202012] Fixed the brief blackout in hostcfgd using SubscriberStateTable #9228

Conversation

vivekrnv commented Nov 10, 2021

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

vivekrnv commented Nov 10, 2021

qiluo-msft Nov 11, 2021 • edited Loading

Choose a reason for hiding this comment

vivekrnv Nov 11, 2021 • edited Loading

Choose a reason for hiding this comment

qiluo-msft Nov 11, 2021

Choose a reason for hiding this comment

vivekrnv Nov 11, 2021

Choose a reason for hiding this comment

vivekrnv commented Nov 11, 2021

mssonicbld commented Nov 11, 2021

azure-pipelines bot commented Nov 11, 2021

vivekrnv commented Nov 12, 2021

mssonicbld commented Nov 12, 2021

azure-pipelines bot commented Nov 12, 2021

vivekrnv commented Nov 12, 2021

mssonicbld commented Nov 12, 2021

azure-pipelines bot commented Nov 12, 2021

vivekrnv commented Nov 15, 2021

mssonicbld commented Nov 15, 2021

azure-pipelines bot commented Nov 15, 2021

dgsudharsan commented Nov 22, 2021

qiluo-msft Nov 22, 2021

Choose a reason for hiding this comment

vivekrnv commented Nov 23, 2021

qiluo-msft Nov 11, 2021 •

edited

Loading

vivekrnv Nov 11, 2021 •

edited

Loading