Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Adjust buffer parameters with 2km cable supported for 4600C non-generic SKUs #9215

Merged
merged 4 commits into from
Dec 8, 2021

Conversation

stephenxs
Copy link
Collaborator

@stephenxs stephenxs commented Nov 10, 2021

Why I did it

Also recalculated all parameters with the latest algorithm with per-speed peer response time taken into account

Signed-off-by: Stephen Sun stephens@nvidia.com

How I did it

Detailed information of each SKU:

  • C64:
    • t0: 32 100G downlinks and 32 100G uplinks
    • t1: 56 100G downlinks and 8 100G uplinks with 2km-cable supported
  • D112C8: 112 50G downlinks and 8 100G uplinks.
  • D48C40: 48 50G downlinks, 32 100G downlinks, and 8 100G uplinks
  • D100C12S2: 4 100G downlinks, 2 10G downlinks, 100 50G downlinks, and 8 100G uplinks

2km cable is supported for C64 on t1 only

How to verify it

Run regression test (QoS)

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Also recalculated all parameters with the latest algorithm
with per-speed peer response time taken into account

Detailed information of each SKU:
- C64: 32 100G down links and 32 100G up links with 2km cable supported on t1
- D112C8: 112 50G down links and 8 100G up links.
- D48C40: 48 50G down links, 32 100G down links and 8 100G up links
- D100C12S2: 4 100G down links, 2 10G down links, 100 50G down links and 8 100G uplinks

2km cable is supported for C64 on t1 only

Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs
Copy link
Collaborator Author

It can be cherry-picked to 202012 cleanly.
For 202106, PR #8242 need to be cherry-picked first and then this one can be cherry-picked cleanly.

Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs
Copy link
Collaborator Author

/azpw run azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@stephenxs
Copy link
Collaborator Author

/azpw run azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs stephenxs marked this pull request as ready for review November 25, 2021 10:23
@liat-grozovik
Copy link
Collaborator

@stephenxs if this was taken into consideration new logic resides only on master/202111 I don't think we should set the label as it cannot be cleanly cherry picked
Please correct me if I am wrong.

@stephenxs
Copy link
Collaborator Author

@stephenxs if this was taken into consideration new logic resides only on master/202111 I don't think we should set the label as it cannot be cleanly cherry picked Please correct me if I am wrong.

As offline discussed, it isn't related to the per speed peer response time for dynamic buffer calculation. So let's request it for 202012 and 202106 (after PR #8242 being cherry-picked).

Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs
Copy link
Collaborator Author

@stephenxs if this was taken into consideration new logic resides only on master/202111 I don't think we should set the label as it cannot be cleanly cherry picked Please correct me if I am wrong.

As offline discussed, it isn't related to the per speed peer response time for dynamic buffer calculation. So let's request it for 202012 and 202106 (after PR #8242 being cherry-picked).

Add "Request for 202106" as the dependent PR has been cherry-picked.

@liat-grozovik liat-grozovik merged commit 2d097de into sonic-net:master Dec 8, 2021
@stephenxs stephenxs deleted the 4600c-2km branch December 8, 2021 13:52
qiluo-msft pushed a commit that referenced this pull request Dec 12, 2021
…C non-generic SKUs (#9215)

- Why I did it
Also recalculated all parameters with the latest algorithm with per-speed peer response time taken into account

- How I did it
Detailed information of each SKU:

C64:
t0: 32 100G downlinks and 32 100G uplinks
t1: 56 100G downlinks and 8 100G uplinks with 2km-cable supported
D112C8: 112 50G downlinks and 8 100G uplinks.
D48C40: 48 50G downlinks, 32 100G downlinks, and 8 100G uplinks
D100C12S2: 4 100G downlinks, 2 10G downlinks, 100 50G downlinks, and 8 100G uplinks
2km cable is supported for C64 on t1 only

- How to verify it
Run regression test (QoS)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs stephenxs added the Request for 202111 Branch For PRs being requested for 202111 branch label Dec 17, 2021
judyjoseph pushed a commit that referenced this pull request Dec 22, 2021
…C non-generic SKUs (#9215)

- Why I did it
Also recalculated all parameters with the latest algorithm with per-speed peer response time taken into account

- How I did it
Detailed information of each SKU:

C64:
t0: 32 100G downlinks and 32 100G uplinks
t1: 56 100G downlinks and 8 100G uplinks with 2km-cable supported
D112C8: 112 50G downlinks and 8 100G uplinks.
D48C40: 48 50G downlinks, 32 100G downlinks, and 8 100G uplinks
D100C12S2: 4 100G downlinks, 2 10G downlinks, 100 50G downlinks, and 8 100G uplinks
2km cable is supported for C64 on t1 only

- How to verify it
Run regression test (QoS)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
judyjoseph pushed a commit that referenced this pull request Dec 27, 2021
…C non-generic SKUs (#9215)

- Why I did it
Also recalculated all parameters with the latest algorithm with per-speed peer response time taken into account

- How I did it
Detailed information of each SKU:

C64:
t0: 32 100G downlinks and 32 100G uplinks
t1: 56 100G downlinks and 8 100G uplinks with 2km-cable supported
D112C8: 112 50G downlinks and 8 100G uplinks.
D48C40: 48 50G downlinks, 32 100G downlinks, and 8 100G uplinks
D100C12S2: 4 100G downlinks, 2 10G downlinks, 100 50G downlinks, and 8 100G uplinks
2km cable is supported for C64 on t1 only

- How to verify it
Run regression test (QoS)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants