Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PINS] Add submit to ingress port to copp_cfg file #9084

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[PINS] Add submit to ingress port to copp_cfg file #9084

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions files/image_config/copp/copp_cfg.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"trap_priority":"4",
"queue": "4"
},
"queue4_group2": {
"queue4_group2": {
"trap_action":"copy",
"trap_priority":"4",
"queue": "4",
Expand Down Expand Up @@ -60,7 +60,10 @@
"trap_action": "trap",
"trap_priority": "1"

}
}{%- if include_p4rt == "y" %},
"trap.group.send_to_ingress" : {
"submit_to_ingress_name" : "send_to_ingress"
Comment on lines +64 to +65
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this to the CONFIG_DB port table?
Issue: we can't specify that this is a host interface for CPU there today.

Can we move this to the P4Orch constructor?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CoPP group has policers and other things. It doesn't really fit here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposal for MVP: put it in P4Orch
Longer term: make this part of the PORT_TABLE

}{% endif %}
},
"COPP_TRAP": {
"bgp": {
Expand Down