[swss.sh] fix an issue that dependent services are not read from a file #8943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is due to the SERVICE variable declared after reading a file Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
liat-grozovik
previously approved these changes
Oct 20, 2021
|
@qiluo-msft could you please help to review and merge? |
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
…services Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
|
@qiluo-msft Please check latest changes. |
qiluo-msft
approved these changes
Oct 26, 2021
judyjoseph
pushed a commit
that referenced
this pull request
Oct 27, 2021
…le (#8943) This is due to the SERVICE variable declared after reading a file #### Why I did it To fix an issue that dhcp_relay does not restart with swss. #### How I did it Fixed in the swss.sh script #### How to verify it sudo systemctl restart swss verify dhcp_relay restarts as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is due to the SERVICE variable declared after reading a file
Signed-off-by: Stepan Blyschak stepanb@nvidia.com
Why I did it
To fix an issue that dhcp_relay does not restart with swss.
How I did it
Fixed in the swss.sh script
How to verify it
sudo systemctl restart swss
verify dhcp_relay restarts as well.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)