Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added aioredis package to snmp container for supporting linkup/down t… #8130

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion dockers/docker-snmp/Dockerfile.j2
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ RUN locale-gen
RUN pip3 install --no-cache-dir \
hiredis \
pyyaml \
smbus
smbus \
aioredis==1.3.0 \
Copy link
Collaborator

@qiluo-msft qiluo-msft Aug 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not install the latest version? Is there anything disruptively changed after 1.3.0? #Closed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tried with version 2.0.1 and trap generation is not working. We need to debug further to find why its failing.
Version 1.3.0 is working fine.

bitstring>=3.1.6

{% if docker_snmp_whls.strip() -%}
# Copy locally-built Python wheel dependencies
Expand Down