Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e1031] add GbE and higig port to E1031 port_config.ini #7208

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

yxieca
Copy link
Contributor

@yxieca yxieca commented Apr 1, 2021

Why I did it

These ports are being enumerated by the latest SAI. But they are not defined in port_config.ini.

SONiC end up trying to delete these 3 ports and hit SAI error and crash.

How I did it

Add the GbE and the 2 HiGig ports in the port_config.ini.

How to verify it

Put the port_config.ini on a device crashing with port deleting. load minigraph and the crash stopped.

Signed-off-by: Ying Xie ying.xie@microsoft.com

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

These ports are being enumerated by the latest SAI. But they are
not defined in port_config.ini.

SONiC end up trying to delete these 3 ports and hit SAI error and
crash.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@Blueve
Copy link
Contributor

Blueve commented Apr 1, 2021

Quote: #6459

@yxieca yxieca merged commit 197dd4e into sonic-net:master Apr 1, 2021
@yxieca yxieca deleted the e1031 branch April 1, 2021 14:46
@daall
Copy link
Contributor

daall commented Apr 2, 2021

@yxieca we don't have the autoneg column in 202012, could you or @Blueve submit a separate PR against 202012 please?

yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Apr 2, 2021
Why I did it
These ports are being enumerated by the latest SAI. But they are not defined in port_config.ini.

SONiC end up trying to delete these 3 ports and hit SAI error and crash.

How I did it
Add the GbE and the 2 HiGig ports in the port_config.ini.

How to verify it
Put the port_config.ini on a device crashing with port deleting. load minigraph and the crash stopped.

Signed-off-by: Ying Xie ying.xie@microsoft.com
yxieca added a commit that referenced this pull request Apr 8, 2021
Why I did it
These ports are being enumerated by the latest SAI. But they are not defined in port_config.ini.

SONiC end up trying to delete these 3 ports and hit SAI error and crash.

How I did it
Add the GbE and the 2 HiGig ports in the port_config.ini.

How to verify it
Put the port_config.ini on a device crashing with port deleting. load minigraph and the crash stopped.

Signed-off-by: Ying Xie ying.xie@microsoft.com
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
Why I did it
These ports are being enumerated by the latest SAI. But they are not defined in port_config.ini.

SONiC end up trying to delete these 3 ports and hit SAI error and crash.

How I did it
Add the GbE and the 2 HiGig ports in the port_config.ini.

How to verify it
Put the port_config.ini on a device crashing with port deleting. load minigraph and the crash stopped.

Signed-off-by: Ying Xie ying.xie@microsoft.com
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
Why I did it
These ports are being enumerated by the latest SAI. But they are not defined in port_config.ini.

SONiC end up trying to delete these 3 ports and hit SAI error and crash.

How I did it
Add the GbE and the 2 HiGig ports in the port_config.ini.

How to verify it
Put the port_config.ini on a device crashing with port deleting. load minigraph and the crash stopped.

Signed-off-by: Ying Xie ying.xie@microsoft.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants