Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sonic-py-common] Relocate some functions from sonic-utilities #5269

Merged
merged 4 commits into from
Aug 30, 2020
Merged

[sonic-py-common] Relocate some functions from sonic-utilities #5269

merged 4 commits into from
Aug 30, 2020

Conversation

judyjoseph
Copy link
Contributor

Move the common multi-asic/general functions from sonic-utilities to py-common
validate_namespace()
get_port_table_name()
get_interface_table_name()

@judyjoseph judyjoseph requested a review from jleveque August 28, 2020 16:43
@judyjoseph judyjoseph mentioned this pull request Aug 28, 2020
Merged
@judyjoseph judyjoseph changed the title Common functions to py-common [sonic-py-common] Common functions to py-common Aug 28, 2020
jleveque
jleveque previously approved these changes Aug 28, 2020
View reviewed changes
@jleveque jleveque changed the title [sonic-py-common] Common functions to py-common [sonic-py-common] Relocate some functions from sonic-utilities Aug 28, 2020
@judyjoseph judyjoseph requested a review from jleveque August 29, 2020 01:26
jleveque
jleveque suggested changes Aug 29, 2020
View reviewed changes
Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recently added a unit test framework for sonic-py-common, and have begun adding unit tests there. Can you please add unit tests for these new functions?

jleveque
jleveque suggested changes Aug 29, 2020
View reviewed changes
@judyjoseph
Copy link
Contributor Author

retest this please

@judyjoseph judyjoseph merged commit ca3e71d into sonic-net:master Aug 30, 2020
@judyjoseph judyjoseph deleted the py_common branch September 1, 2020 15:43
abdosi pushed a commit that referenced this pull request Sep 6, 2020
@judyjoseph @abdosi
[sonic-py-common] Relocate some functions from sonic-utilities (#5269)
cbc6de8 
* Relocate interface related common functions to py-common
* Add unit tests for interface API's.
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
@judyjoseph @santhosh-kt
[sonic-py-common] Relocate some functions from sonic-utilities (sonic…
0d8a43e 
…-net#5269)

* Relocate interface related common functions to py-common
* Add unit tests for interface API's.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleveque jleveque jleveque approved these changes

Assignees
No one assigned
Labels
Enhancement ➕ Included in 201911 Branch Request for 201911 Branch :shipit: sonic-py-common
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@judyjoseph @jleveque @abdosi