[platform] Add Support For Environment Variable File #5010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tahmed-dev
force-pushed
the
taahme/add-support-for-sonic-envvars
branch
from
5261f5f
to
9b03c94
Compare
jleveque
reviewed
Jul 21, 2020
platform/broadcom/sonic-platform-modules-dell/s6000/scripts/s6000_platform.sh
Show resolved
Hide resolved
qiluo-msft
reviewed
Jul 21, 2020
tahmed-dev
changed the title
pavel-shirshov
previously approved these changes
Jul 24, 2020
lguohan
reviewed
Jul 24, 2020
|
there is a build failure, looks like related to your change. |
Looking into it this failure. |
jleveque
reviewed
Jul 25, 2020
This PR adds the ability to read environment file from /etc/sonic. the file contains immutable SONiC config attributes such as platform, hwsku, version, device_type. The aim is to minimize calls being made into sonic-cfggen during boot time. singed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
1. move sonic-environment relocation from union-mount to rc.local 2. remove SONIC_HOSTNAME envvar
tahmed-dev
force-pushed
the
taahme/add-support-for-sonic-envvars
branch
from
c68086d
to
1ed0981
Compare
lguohan
approved these changes
Jul 28, 2020
pavel-shirshov
approved these changes
Jul 31, 2020
jleveque
suggested changes
Jul 31, 2020
Comment on lines
+10
to
+11
| PLATFORM=${PLATFORM:-`sonic-cfggen -H -v DEVICE_METADATA.localhost.platform`} | ||
| HWSKU=${HWSKU:-`sonic-cfggen -d -v 'DEVICE_METADATA["localhost"]["hwsku"]'`} |
There was a problem hiding this comment.
Suggest using the same syntax for these variables. Either change former to 'DEVICE_METADATA["localhost"]["platform"]' or change latter to DEVICE_METADATA.localhost.hwsku
Comment on lines
+16
to
+17
| PLATFORM=${PLATFORM:-`sonic-cfggen -H -v DEVICE_METADATA.localhost.platform`} | ||
| HWSKU=${HWSKU:-`sonic-cfggen -d -v 'DEVICE_METADATA["localhost"]["hwsku"]'`} |
There was a problem hiding this comment.
Suggest using the same syntax for these variables. Either change former to 'DEVICE_METADATA["localhost"]["platform"]' or change latter to DEVICE_METADATA.localhost.hwsku
jleveque
approved these changes
Jul 31, 2020
abdosi
pushed a commit
that referenced
this pull request
Sep 28, 2020
* [platform] Add Support For Environment Variable This PR adds the ability to read environment file from /etc/sonic. the file contains immutable SONiC config attributes such as platform, hwsku, version, device_type. The aim is to minimize calls being made into sonic-cfggen during boot time. singed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
* [platform] Add Support For Environment Variable This PR adds the ability to read environment file from /etc/sonic. the file contains immutable SONiC config attributes such as platform, hwsku, version, device_type. The aim is to minimize calls being made into sonic-cfggen during boot time. singed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to read environment file from /etc/sonic.
the file contains immutable SONiC config attributes such as platform,
hwsku, version, device_type. The aim is to minimize calls being made
into sonic-cfggen during boot time.
singed-off-by: Tamer Ahmed tamer.ahmed@microsoft.com
- Why I did it
Added ability to read environment var file
- How I did it
New code that detect presence of such file during bootstrapping an image, the file is then moved to /etc/sonic
- How to verify it
This is infra work and image should boot normally in the absence of such file.
- Description for the changelog