Add the test signing certificates for secure boot #4866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Jun 29, 2020
|
|
||
| # If the ca certificate does not exist, the test certificate will be used to sign the image | ||
| if [ ! -f "$CA_CERT" ]; then | ||
| TEST_CERT_PATH=files/image_config/secureboot/test-certs |
There was a problem hiding this comment.
add local ?
And change variable name to lower case. #Closed
There was a problem hiding this comment.
Seems it cannot be changed to local, it only can be used in a function.
qiluo-msft
reviewed
Jun 29, 2020
| @@ -0,0 +1,51 @@ | |||
| -----BEGIN RSA PRIVATE KEY----- | |||
There was a problem hiding this comment.
Do you need this file in build process?
There was a problem hiding this comment.
Removed and regenerate the certificates.
qiluo-msft
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
Check in the test certificates to sign aboot image for secure boot, if the certificates not specified, the test certificates will be used. The certificates are only for test, not for product.
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)