Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sonic-platform-common][sonic-platform-daemons][sonic-utilities] Update submodules #4852

Merged
merged 4 commits into from
Jun 28, 2020
Merged

[sonic-platform-common][sonic-platform-daemons][sonic-utilities] Update submodules #4852

merged 4 commits into from
Jun 28, 2020

Conversation

jleveque
Copy link
Contributor

@jleveque jleveque commented Jun 25, 2020 •
edited
Loading

Note: sonic-utilities update fixes #4716

@jleveque
[sonic-platform-common][sonic-platform-daemons][sonic-utilities] Update
06ff6df 
submodules

* src/sonic-platform-common 75698a8...85edabb (8):
  > [sfp_base] Update return value documentation of channel-specific
methods (#98)
  > [sfp] Tweak key names of some transceiver info fields (#97)
  > fix typo:  portconfig.ini to port_config.ini (#94)
  > [chassis_base] Add platform API support for system LED (#91)
  > Add PCIe check commad  (#64)
  > [sfputilbase.py] Don't try to print EEPROM sysfs file name if we
failed to read from it (#81)
  > [sfputilbase | sfputilhelper] Add support of platform.json (#72)
  > [eeprom] Add try-except to catch the IOError (#85)

* src/sonic-platform-daemons 0f4fd83...abe115e (2):
  > [xcvrd] Tweak some transceiver info key names (#62)
  > [psud][thermalctld] Always get fan/PSU LED status from platform API
to avoid status inconsistencies (#59)

* src/sonic-utilities fd7781b...fa19b4c (5):
  > [sfpshow][mock_state_db] Tweak key names of some transceiver info
fields (#958)
  > [show] Add missing verbose option to "show line" (#961)
  > [filter-fdb] Check VLAN Presence When Filter FDB (#957)
  > [master]fix #4716 show ipv6 interfaces neighbor_ip is N/A issue
(#948)
  > Fix for command. show interface transceiver eeprom -d Ethernet
(#955)
@jleveque jleveque requested a review from lguohan June 25, 2020 21:53
@jleveque jleveque self-assigned this Jun 25, 2020
@qiluo-msft
Copy link
Collaborator

qiluo-msft
qiluo-msft previously approved these changes Jun 26, 2020
View reviewed changes
@jleveque
Copy link
Contributor Author

@qiluo-msft: Thanks for documenting the new commits you pulled in. I have added them to the description.

@jleveque jleveque marked this pull request as draft June 27, 2020 01:17
@jleveque
Copy link
Contributor Author

jleveque commented Jun 27, 2020 •
edited
Loading

Converted to draft to wait until sonic-net/sonic-utilities#965 merges, then I will pull that commit into the sonic-utilities submodule update.

Edit: Will also wait for sonic-net/sonic-utilities#966

@qiluo-msft
Copy link
Collaborator

It is okay to merge this when new fixes are not immediately ready.

@qiluo-msft qiluo-msft marked this pull request as ready for review June 27, 2020 16:54
@jleveque
Copy link
Contributor Author

Advanceds sonic-utilities by two more commits:

@jleveque
Copy link
Contributor Author

Advanced sonic-platform-common by one more commit:

@jleveque jleveque merged commit ced0f7b into sonic-net:master Jun 28, 2020
@jleveque jleveque deleted the update_submodules branch June 28, 2020 05:57
pjaipakdee19 pushed a commit to pjaipakdee19/sonic-buildimage that referenced this pull request Jul 7, 2020
@jleveque @pjaipakdee19
[sonic-platform-common][sonic-platform-daemons][sonic-utilities] Upda…
217137e 
…te submodules (sonic-net#4852)

* src/sonic-platform-common 75698a8...82bbeab (9):
  > [sfputil] Make SfpUtilHelper.get_physical_to_logical noexcept as in SfpUtilBase (sonic-net#96)
  > [sfp_base] Update return value documentation of channel-specific methods (sonic-net#98)
  > [sfp] Tweak key names of some transceiver info fields (sonic-net#97)
  > fix typo:  portconfig.ini to port_config.ini (sonic-net#94)
  > [chassis_base] Add platform API support for system LED (sonic-net#91)
  > Add PCIe check commad  (sonic-net#64)
  > [sfputilbase.py] Don't try to print EEPROM sysfs file name if we failed to read from it (sonic-net#81)                                                                                    
  > [sfputilbase | sfputilhelper] Add support of platform.json (sonic-net#72)
  > [eeprom] Add try-except to catch the IOError (sonic-net#85)

* src/sonic-platform-daemons 0f4fd83...abe115e (2):
  > [xcvrd] Tweak some transceiver info key names (sonic-net#62)
  > [psud][thermalctld] Always get fan/PSU LED status from platform API to avoid status inconsistencies (sonic-net#59)                                                                        

* src/sonic-utilities fd7781b...16a33f2 (9):
  > [config] Fix syntax error (sonic-net#966)
  > [config] Fix indentation level in _get_disabled_services_list() (sonic-net#965)
  > a4e64d1 [sonic_installer] Refactor sonic_installer code (sonic-net#953)
  > 90efd62 [Show | Command Reference] Add Port breakout Show Command (sonic-net#859)
  > [sfpshow][mock_state_db] Tweak key names of some transceiver info fields (sonic-net#958)
  > [show] Add missing verbose option to "show line" (sonic-net#961)
  > [filter-fdb] Check VLAN Presence When Filter FDB (sonic-net#957)
  > [master]fix sonic-net#4716 show ipv6 interfaces neighbor_ip is N/A issue (sonic-net#948)
  > Fix for command. show interface transceiver eeprom -d Ethernet (sonic-net#955)

Note: sonic-utilities update fixes sonic-net#4716
taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this pull request Apr 28, 2022
@xwjiang-ms
[config] Fix snmpagentaddress doesn't support the uppercase letters f…
9e50124 
…or ipv6 address (sonic-net#1989)

* [config] Fix snmpagentaddress doesn't support the uppercase letters for ipv6 address (sonic-net#4852)

	-What I did
	Snmpagentaddress now support upper letters input for ipv6 address
	Fix some grammer mistakes

	-How I did
	Convert all agentip to lower letters to match netifaces addresses
	delete ; after break, convert addfress to address

	-How to verify it
	'sudo config snmpagentaddress add FC00:1::32 -v mgmt'
	The ipv6 address can be obtained by command 'sudo ifconfig'

* [config] Change the way to solve issue 4852

-What I did
Snmpagentaddress now support upper letters input for ipv6 address

-How I did
Compare the lower letter of input and netifaces addresses

-How to verify it
'sudo config snmpagentaddress add FC00:1::32 -v mgmt'
The ipv6 address can be obtained by command 'sudo ifconfig'

Co-authored-by: Ubuntu <xiawei@xiawei-vm-01.tisdilhqf3cutp031mpllu05ca.syx.internal.cloudapp.net>
Co-authored-by: xwjiang2021 <xwjiang2021@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

Assignees

@jleveque jleveque

Labels
Submodule Update ⏫
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

show ipv6 interfaces command result doesn't conclude neighbor ipv6 address
2 participants
@jleveque @qiluo-msft