-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[secureboot] only remove exec bit in secureboot #4836
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@qiluo-msft, can you link the issue in the pr? |
retest vsimage please |
Retest vsimage please |
@jleveque Please do not retest when there is one already running. Sometimes there are multiple triggered, and each finished one will mark failure here. I aborted the latest one. Thanks for your helping! |
@qiluo-msft: The vsimage check build was showing as failed, which is why I issued the retest. If it was still running, it wasn't reflected properly here. |
Retest vsimage please |
This fixes #4646 |
Interesting. GitHub used to display "<user x> authored and <user y> committed". Maybe something changed with the new redesign? |
No worries, I don't mind it. The fix was the important thing ^^ |
It turns out somehow I mistakenly merge instead of squash merge, so there is fork and merge in the history and your original commit is also in the history before. |
Address issue #4832