Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[secureboot] only remove exec bit in secureboot #4836

Merged
merged 1 commit into from
Jun 25, 2020

Conversation

Staphylo
Copy link
Collaborator

Address issue #4832

Copy link
Collaborator

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lguohan lguohan linked an issue Jun 23, 2020 that may be closed by this pull request
@lguohan
Copy link
Collaborator

lguohan commented Jun 23, 2020

@qiluo-msft, can you link the issue in the pr?

@daall
Copy link
Contributor

daall commented Jun 23, 2020

retest vsimage please

@jleveque
Copy link
Contributor

Retest vsimage please

@qiluo-msft
Copy link
Collaborator

@jleveque Please do not retest when there is one already running. Sometimes there are multiple triggered, and each finished one will mark failure here. I aborted the latest one. Thanks for your helping!

@jleveque
Copy link
Contributor

jleveque commented Jun 24, 2020

@qiluo-msft: The vsimage check build was showing as failed, which is why I issued the retest. If it was still running, it wasn't reflected properly here.

@lguohan
Copy link
Collaborator

lguohan commented Jun 25, 2020

Retest vsimage please

@ciju-juniper
Copy link
Contributor

This fixes #4646
Built an image and tested.

@qiluo-msft qiluo-msft merged commit 719c8e6 into sonic-net:master Jun 25, 2020
@qiluo-msft
Copy link
Collaborator

Sorry @Staphylo, I don't know what happens to Github. After I merge this PR, the commit shows my name 719c8e6

Credit should go to you.

@jleveque
Copy link
Contributor

jleveque commented Jun 26, 2020

Interesting. GitHub used to display "<user x> authored and <user y> committed". Maybe something changed with the new redesign?

@Staphylo
Copy link
Collaborator Author

No worries, I don't mind it. The fix was the important thing ^^

@qiluo-msft
Copy link
Collaborator

It turns out somehow I mistakenly merge instead of squash merge, so there is fork and merge in the history and your original commit is also in the history before.

@Staphylo Staphylo deleted the master-secureboot-exec branch December 6, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permission issues with latest SONiC images
6 participants